Make searching for a bundle's basket name work.

Make searching for a bundle's basket name work.

The search field was incorrectly listed as 'basket' not 'basket_name'.
Also when creating a new test to search for the basket name using the old
test data 'wordpress-basket' the test inexplicably passed even when the
search code was broken.  Upon reflection it is due to the way the search
term is tokenized.  The test was updated to use a unique term for the
basket name which solved the false positive problem.

https://code.launchpad.net/~bac/charmworld/bug-1246459/+merge/193593

(do not edit description out of merge proposal)

[bac, 2013-11-01 13:01:27]

Please take a look.

[bac, 2013-11-01 13:09:26]

I forgot to mention, for QA purposes I have created a bundle on LP with a unique
basket id to use for searching.  Locally do this before running charmworld:

HOME=_run INI=charmworld.ini bin/enqueue --prefix=~charmers/charms/precise
HOME=_run INI=charmworld.ini bin/enqueue --prefix=~bac/charms/bundles
HOME=_run INI=charmworld.ini bin/ingest-queued

Then search for the text 'muletrain'.  For bonus points explain why the rails
charm shows up.  Is it because the substring 'rai' matches?

https://codereview.appspot.com/20780043/diff/1/charmworld/tests/test_search.py
File charmworld/tests/test_search.py (right):

https://codereview.appspot.com/20780043/diff/1/charmworld/tests/test_search.p...
charmworld/tests/test_search.py:176: def
test_store_bundles_basket_name_indexed(self):
This new test initially worked even before the search code was fixed when it was
using 'wordpress-basket' as the search term.  Was a little disturbing.

[rharding, 2013-11-01 14:18:28]

code looks good with one scoring comment. Doing QA

https://codereview.appspot.com/20780043/diff/1/charmworld/search.py
File charmworld/search.py (right):

https://codereview.appspot.com/20780043/diff/1/charmworld/search.py#newcode46
charmworld/search.py:46: 'basket_name': 5,
we were thinking the basket name is the priority field. Should it get the 10 and
the name get the 5?

https://codereview.appspot.com/20780043/diff/1/charmworld/tests/test_search.py
File charmworld/tests/test_search.py (right):

https://codereview.appspot.com/20780043/diff/1/charmworld/tests/test_search.p...
charmworld/tests/test_search.py:155: _id =
'~abentley/{}/5/wordpress-stage'.format(self.basket_name)
shoot, I missed we could .format() now that a late enough python is in precise.
I've still been under the % spell.

[benji, 2013-11-01 15:55:00]

QA LGTM