toward-stem-shift-in-column should only consider 'script-interface

toward-stem-shift-in-column should only consider 'script-interface

Previously, toward-stem-shift-in-column did not discriminate between
different types of grobs in the 'scripts grob-array.  This meant that
TextScript, StringNumber, and Fingering objects would be caught as well.
This patch only shifts an articulation in the presence of another Script
grob.

[david.nalesnik, 2015-03-09 15:40:17]

Please review.  Thanks.

[david.nalesnik, 2015-03-09 17:09:24]

https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm
File scm/output-lib.scm (right):

https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm#newcod...
scm/output-lib.scm:1195: (and (not (eq? s grob))
I am recognizing Script grobs in the orthodox way--i.e., through interfaces. 
This would be considerably less cluttered if I used
(grob::name s 'Script)
instead.

[david.nalesnik, 2015-03-09 17:14:09]

https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm
File scm/output-lib.scm (right):

https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm#newcod...
scm/output-lib.scm:1195: (and (not (eq? s grob))
On 2015/03/09 17:09:23, david.nalesnik wrote:
> I am recognizing Script grobs in the orthodox way--i.e., through interfaces. 
> This would be considerably less cluttered if I used
> (grob::name s 'Script)
> instead.

That would be

(eq? (grob::name s) 'Script)

[thomasmorley651, 2015-03-11 23:49:44]

https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm
File scm/output-lib.scm (right):

https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm#newcod...
scm/output-lib.scm:1190: (shift (if (and (ly:grob? script-column)
minor nit:
Is it possible to stick to the 80 characters line-width?

https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm#newcod...
scm/output-lib.scm:1196: (grob::has-interface s 'script-interface)
Is there any need to go for AccidentalSuggestion and DynamicText?
Deleting these conditions seems to make no difference:

{
  \time 3/4
  \voiceOne
  c'!2.-.
  c'2.-. \ffff
}

Looks ok, even with unpatched 2.19.16

[thomasmorley651, 2015-03-12 00:01:35]

https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm
File scm/output-lib.scm (right):

https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm#newcod...
scm/output-lib.scm:1196: (grob::has-interface s 'script-interface)
On 2015/03/11 23:49:44, thomasmorley651 wrote:
> Is there any need to go for AccidentalSuggestion and DynamicText?
> Deleting these conditions seems to make no difference:
> 
> {
>   \time 3/4
>   \voiceOne
>   c'!2.-.
>   c'2.-. \ffff
> }
> 
> Looks ok, even with unpatched 2.19.16

Ok, I'm wrong with Accidentalsuggestion, it makes a difference!
Though, I found no example for DynamicText, returning bad output with 2.19.16

[david.nalesnik, 2015-03-12 16:35:41]

Thanks for the review!

https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm
File scm/output-lib.scm (right):

https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm#newcod...
scm/output-lib.scm:1190: (shift (if (and (ly:grob? script-column)
On 2015/03/11 23:49:44, thomasmorley651 wrote:
> minor nit:
> Is it possible to stick to the 80 characters line-width?

Done.

https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm#newcod...
scm/output-lib.scm:1196: (grob::has-interface s 'script-interface)
On 2015/03/12 00:01:35, thomasmorley651 wrote:
> On 2015/03/11 23:49:44, thomasmorley651 wrote:
> > Is there any need to go for AccidentalSuggestion and DynamicText?
> > Deleting these conditions seems to make no difference:
> > 
> > {
> >   \time 3/4
> >   \voiceOne
> >   c'!2.-.
> >   c'2.-. \ffff
> > }
> > 
> > Looks ok, even with unpatched 2.19.16
> 
> Ok, I'm wrong with Accidentalsuggestion, it makes a difference!
> Though, I found no example for DynamicText, returning bad output with 2.19.16
> 
> 

Done.

You are right about DynamicText.  Though it has script-interface, it will not be
caught in the 'scripts array of ScriptColumn.  Check removed.

[thomasmorley651, 2015-03-16 22:13:12]

LGTM