Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(478)

Issue 207620043: toward-stem-shift-in-column should only consider 'script-interface

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 7 months ago by david.nalesnik
Modified:
4 years, 7 months ago
Reviewers:
thomasmorley651
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

toward-stem-shift-in-column should only consider 'script-interface Previously, toward-stem-shift-in-column did not discriminate between different types of grobs in the 'scripts grob-array. This meant that TextScript, StringNumber, and Fingering objects would be caught as well. This patch only shifts an articulation in the presence of another Script grob.

Patch Set 1 #

Patch Set 2 : just Script grobs #

Total comments: 7

Patch Set 3 : Harm's review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M scm/output-lib.scm View 1 chunk +13 lines, -2 lines 0 comments Download

Messages

Total messages: 7
david.nalesnik
Please review. Thanks.
4 years, 7 months ago (2015-03-09 15:40:17 UTC) #1
david.nalesnik
https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm#newcode1195 scm/output-lib.scm:1195: (and (not (eq? s grob)) I am recognizing Script ...
4 years, 7 months ago (2015-03-09 17:09:24 UTC) #2
david.nalesnik
https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm#newcode1195 scm/output-lib.scm:1195: (and (not (eq? s grob)) On 2015/03/09 17:09:23, david.nalesnik ...
4 years, 7 months ago (2015-03-09 17:14:09 UTC) #3
thomasmorley651
https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm#newcode1190 scm/output-lib.scm:1190: (shift (if (and (ly:grob? script-column) minor nit: Is it ...
4 years, 7 months ago (2015-03-11 23:49:44 UTC) #4
thomasmorley651
https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm#newcode1196 scm/output-lib.scm:1196: (grob::has-interface s 'script-interface) On 2015/03/11 23:49:44, thomasmorley651 wrote: > ...
4 years, 7 months ago (2015-03-12 00:01:35 UTC) #5
david.nalesnik
Thanks for the review! https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm#newcode1190 scm/output-lib.scm:1190: (shift (if (and (ly:grob? script-column) ...
4 years, 7 months ago (2015-03-12 16:35:41 UTC) #6
thomasmorley651
4 years, 7 months ago (2015-03-16 22:13:12 UTC) #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b