Issue 207074: Catch URI parsing RuntimeException in OAuthRequest

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 207074: Catch URI parsing RuntimeException in OAuthRequest (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 2 months ago by johnfargo

Modified:
16 years, 1 month ago

Reviewers:
Paul Lindner, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

Improves error handling for this case.

Patch Set 1 #

Created: 16 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java	View		1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

johnfargo

Thanks Paul; committed. On Thu, Feb 11, 2010 at 5:03 PM, <lindner@inuus.com> wrote: > lgtm ...

16 years, 2 months ago (2010-02-12 01:05:34 UTC) #3

zhoresh

16 years, 2 months ago (2010-02-12 01:06:24 UTC) #4

Maybe also catch error for decodeForm in line 497 and 591?

On Thu, Feb 11, 2010 at 4:57 PM, <johnfargo@gmail.com> wrote:

> Reviewers: shindig.remailer_gmail.com,
>
> Description:
> Improves error handling for this case.
>
> Please review this at http://codereview.appspot.com/207074/show
>
> Affected files:
>
>  java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java
>
>
> Index:
> java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java
> ===================================================================
> ---
> java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java
>   (revision 909189)
> +++
> java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java
>   (working copy)
> @@ -500,7 +500,13 @@
>       case URL_ONLY:
>         break;
>       case URL_AND_FORM_PARAMS:
> -
>  params.addAll(sanitize(OAuth.decodeForm(base.getPostBodyAsString())));
> +        try {
> +
>  params.addAll(sanitize(OAuth.decodeForm(base.getPostBodyAsString())));
> +        } catch (IllegalArgumentException e) {
> +          // Occurs if OAuth.decodeForm finds an invalid URL to decode.
> +          throw
> responseParams.oauthRequestException(OAuthError.INVALID_REQUEST,
> +              "Could not decode body", e);
> +        }
>         break;
>       case URL_AND_BODY_HASH:
>         try {
>
>
>

Expand All Messages | Collapse All Messages