Issue 206860043: code review 206860043: freetype/raster: fix some style nits.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 206860043: code review 206860043: freetype/raster: fix some style nits. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by nigeltao

Modified:
9 years, 7 months ago

Reviewers:
crawshaw

CC:
crawshaw, golang-codereviews

Visibility:
Public.

Description

freetype/raster: fix some style nits. This code dates from before Go 1.0.

Patch Set 1 #

Patch Set 2 : diff -r 4ee4916a76ae3d8090397720251cef12f830a1ec https://code.google.com/p/freetype-go #

Patch Set 3 : diff -r 4ee4916a76ae3d8090397720251cef12f830a1ec https://code.google.com/p/freetype-go #

Patch Set 4 : diff -r 4ee4916a76ae3d8090397720251cef12f830a1ec https://code.google.com/p/freetype-go #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -64 lines)			Patch
M	freetype/raster/geom.go	View	1	2 chunks	+7 lines, -47 lines	0 comments	Download
M	freetype/raster/paint.go	View	1	3 chunks	+6 lines, -6 lines	0 comments	Download
M	freetype/raster/raster.go	View	1	4 chunks	+10 lines, -10 lines	0 comments	Download
M	freetype/raster/stroke.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello crawshaw@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/freetype-go

9 years, 7 months ago (2015-02-23 06:07:06 UTC) #1

nigeltao

9 years, 7 months ago (2015-02-23 23:53:07 UTC) #3

*** Submitted as
https://code.google.com/p/freetype-go/source/detail?r=94364c05edf5 ***

freetype/raster: fix some style nits.

This code dates from before Go 1.0.

LGTM=crawshaw
R=crawshaw
CC=golang-codereviews
https://codereview.appspot.com/206860043

Expand All Messages | Collapse All Messages