Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1689)

Issue 206770043: Let \displayLilyMusic print even repeated durations (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 1 month ago by dak
Modified:
8 years, 9 months ago
Reviewers:
Keith
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Let \displayLilyMusic print even repeated durations \displayLilyMusic { c4 c c c } now produces { c4 c4 c4 c4 } in order to better match the content of the music rather than the shortest possible input representation.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add Changes entry #

Patch Set 3 : Indeed. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -133 lines) Patch
M Documentation/changes.tely View 1 2 1 chunk +9 lines, -0 lines 3 comments Download
M Documentation/extending/scheme-tutorial.itely View 1 1 chunk +1 line, -1 line 0 comments Download
M Documentation/notation/input.itely View 1 1 chunk +1 line, -1 line 0 comments Download
M input/regression/display-lily-tests.ly View 5 chunks +86 lines, -86 lines 0 comments Download
M scm/define-music-display-methods.scm View 12 chunks +23 lines, -34 lines 0 comments Download
M scm/display-lily.scm View 2 chunks +6 lines, -9 lines 0 comments Download
M scm/music-functions.scm View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7
Keith
That is unfortunate, but I can't think of anything better. I use \displayLilyMusic mostly to ...
9 years, 1 month ago (2015-02-25 06:11:55 UTC) #1
dak
https://codereview.appspot.com/206770043/diff/1/scm/define-music-display-methods.scm File scm/define-music-display-methods.scm (left): https://codereview.appspot.com/206770043/diff/1/scm/define-music-display-methods.scm#oldcode522 scm/define-music-display-methods.scm:522: (duration->lily-string (ly:music-property note 'duration) On 2015/02/25 06:11:55, Keith wrote: ...
9 years, 1 month ago (2015-02-25 08:25:45 UTC) #2
dak
On 2015/02/25 06:11:55, Keith wrote: > That is unfortunate, but I can't think of anything ...
9 years, 1 month ago (2015-02-25 09:51:50 UTC) #3
dak
Add Changes entry
9 years, 1 month ago (2015-02-25 18:41:17 UTC) #4
dak
Indeed.
9 years, 1 month ago (2015-02-26 07:16:44 UTC) #5
Keith
looks fine. https://codereview.appspot.com/206770043/diff/40001/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/206770043/diff/40001/Documentation/changes.tely#newcode522 Documentation/changes.tely:522: longer omit redundant note durations. This makes ...
9 years, 1 month ago (2015-02-27 05:11:57 UTC) #6
dak
9 years, 1 month ago (2015-02-27 08:56:21 UTC) #7
https://codereview.appspot.com/206770043/diff/40001/Documentation/changes.tely
File Documentation/changes.tely (right):

https://codereview.appspot.com/206770043/diff/40001/Documentation/changes.tel...
Documentation/changes.tely:522: longer omit redundant note durations.  This
makes it easier to
On 2015/02/27 05:11:56, Keith wrote:
> Maybe just skip the second sentence altogether; it could only confuse.  
Things
> are no easier for the user, and nobody cares if the programming is easier.

If "programming" means manipulating the result with some editor like with a
search-and-replace operation, some people might care.  It also makes it easier
to cut&paste such outputs together.  Which is for the user.

The second sentence cannot really be omitted without leaving the example in the
lurch, and I think that the change warrants at least this bit of illustrative
rationale.  If you have a better suggestion, go ahead.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b