Issue 20640043: code review 20640043: [release-branch.go1.2] time: correct path to time zone ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 20640043: code review 20640043: [release-branch.go1.2] time: correct path to time zone ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by adg

Modified:
11 years, 6 months ago

Reviewers:
dsymonds

CC:
golang-dev

Visibility:
Public.

Description

[release-branch.go1.2] time: correct path to time zone zip file on Unix ««« CL 19280043 / 9d199c7582d6 time: correct path to time zone zip file on Unix Most Unix systems have their own time zone data, so we almost never get far enough in the list to discover that we cannot fall back to the zip file. Adjust testing to exercise the final fallback. Plan 9 and Windows were already correct (and are the main users of the zip file). R=golang-dev, bradfitz CC=golang-dev https://codereview.appspot.com/19280043 »»»

Patch Set 1 #

Patch Set 2 : diff -r 4ca5466d4896 https://code.google.com/p/go #

Patch Set 3 : diff -r 4ca5466d4896 https://code.google.com/p/go #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -2 lines)			Patch
M	src/pkg/time/export_test.go	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/pkg/time/time_test.go	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/pkg/time/zoneinfo_plan9.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/pkg/time/zoneinfo_unix.go	View	1	1 chunk	+13 lines, -1 line	0 comments	Download
M	src/pkg/time/zoneinfo_windows.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 6 months ago (2013-11-01 00:28:40 UTC) #1

adg

*** Submitted as https://code.google.com/p/go/source/detail?r=9bb74c69e851 *** [release-branch.go1.2] time: correct path to time zone zip file on ...

11 years, 6 months ago (2013-11-01 00:29:05 UTC) #2

LGTM

Expand All Messages | Collapse All Messages