Review PEP 371 patch 1

This is the initial patch for PEP 371 including all docs and tests, see http://bugs.python.org/issue3050 for background

[Georg, 2008-06-10 19:23:57]

http://codereview.appspot.com/2061/diff/1/21
File setup.py (right):

http://codereview.appspot.com/2061/diff/1/21#newcode1285
Line 1285: mmacros = [(k, v) for k, v in macros.iteritems()]
Isn't that just macros.items() like used below?

[jnoller, 2008-06-10 19:35:26]

http://codereview.appspot.com/2061/diff/1/21
File setup.py (right):

http://codereview.appspot.com/2061/diff/1/21#newcode1285
Line 1285: mmacros = [(k, v) for k, v in macros.iteritems()]
On 2008/06/10 19:23:57, Georg wrote:
> Isn't that just macros.items() like used below?

Thanks for catching that, I didn't mean for that to get in there

[Benjamin, 2008-06-10 20:50:51]

I gave everything a quick look over. Overall, the code is well-commented and
clean. I didn't find anything serious. Mostly I just made suggestions. If you
only need it to run on 2.6, I can make a bunch of suggestions (like using
str.format). If you don't, that's fine too.

Thanks very much.

http://codereview.appspot.com/2061/diff/1/39
File Lib/multiprocessing/__init__.py (right):

http://codereview.appspot.com/2061/diff/1/39#newcode53
Line 53: 
Would you like to add __author__?

http://codereview.appspot.com/2061/diff/1/39#newcode62
Line 62: from multiprocessing.process import Process, current_process,
active_children
Do you want to use relative imports?

http://codereview.appspot.com/2061/diff/1/40
File Lib/multiprocessing/connection.py (right):

http://codereview.appspot.com/2061/diff/1/40#newcode31
Line 31: bytes = str                  # XXX not needed in 2.6 and 3.0
Can this go or do you want to maintain backwards-compatibility?

http://codereview.appspot.com/2061/diff/1/38
File Lib/multiprocessing/sharedctypes.py (right):

http://codereview.appspot.com/2061/diff/1/38#newcode69
Line 69: lock = kwds.pop('lock', None)
In Py3k, lock can become a keyword-only argument for real.

http://codereview.appspot.com/2061/diff/1/32
File Lib/multiprocessing/synchronize.py (right):

http://codereview.appspot.com/2061/diff/1/32#newcode112
Line 112: if threading.currentThread().getName() != 'MainThread':
Once I get the new threading API checked in, it can be used.