Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2057)

Issue 2061: Review PEP 371 patch 1

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by jnoller
Modified:
12 years, 2 months ago
Reviewers:
Benjamin, Georg
Base URL:
http://svn.python.org/view/*checkout*/python/trunk/
Visibility:
Public.

Description

This is the initial patch for PEP 371 including all docs and tests, see http://bugs.python.org/issue3050 for background

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12509 lines, -0 lines) Patch
Doc/includes/mp_benchmarks.py View 1 chunk +235 lines, -0 lines 0 comments Download
Doc/includes/mp_distributing.py View 1 chunk +362 lines, -0 lines 0 comments Download
Doc/includes/mp_newtype.py View 1 chunk +98 lines, -0 lines 0 comments Download
Doc/includes/mp_pool.py View 1 chunk +311 lines, -0 lines 0 comments Download
Doc/includes/mp_synchronize.py View 1 chunk +273 lines, -0 lines 0 comments Download
Doc/includes/mp_webserver.py View 1 chunk +67 lines, -0 lines 0 comments Download
Doc/includes/mp_workers.py View 1 chunk +87 lines, -0 lines 0 comments Download
Doc/library/multiprocessing.rst View 1 chunk +2108 lines, -0 lines 0 comments Download
Doc/library/someos.rst View 1 chunk +1 line, -0 lines 0 comments Download
Lib/multiprocessing/__init__.py View 1 chunk +267 lines, -0 lines 2 comments Download
Lib/multiprocessing/connection.py View 1 chunk +434 lines, -0 lines 1 comment Download
Lib/multiprocessing/dummy/__init__.py View 1 chunk +143 lines, -0 lines 0 comments Download
Lib/multiprocessing/dummy/connection.py View 1 chunk +61 lines, -0 lines 0 comments Download
Lib/multiprocessing/forking.py View 1 chunk +429 lines, -0 lines 0 comments Download
Lib/multiprocessing/heap.py View 1 chunk +201 lines, -0 lines 0 comments Download
Lib/multiprocessing/managers.py View 1 chunk +1092 lines, -0 lines 0 comments Download
Lib/multiprocessing/pool.py View 1 chunk +596 lines, -0 lines 0 comments Download
Lib/multiprocessing/process.py View 1 chunk +302 lines, -0 lines 0 comments Download
Lib/multiprocessing/queues.py View 1 chunk +356 lines, -0 lines 0 comments Download
Lib/multiprocessing/reduction.py View 1 chunk +190 lines, -0 lines 0 comments Download
Lib/multiprocessing/sharedctypes.py View 1 chunk +234 lines, -0 lines 1 comment Download
Lib/multiprocessing/synchronize.py View 1 chunk +294 lines, -0 lines 1 comment Download
Lib/multiprocessing/util.py View 1 chunk +336 lines, -0 lines 0 comments Download
Lib/test/test_multiprocessing.py View 1 chunk +1791 lines, -0 lines 0 comments Download
Modules/_multiprocessing/connection.h View 1 chunk +515 lines, -0 lines 0 comments Download
Modules/_multiprocessing/multiprocessing.h View 1 chunk +163 lines, -0 lines 0 comments Download
Modules/_multiprocessing/multiprocessing.c View 1 chunk +308 lines, -0 lines 0 comments Download
Modules/_multiprocessing/pipe_connection.c View 1 chunk +136 lines, -0 lines 0 comments Download
Modules/_multiprocessing/semaphore.c View 1 chunk +625 lines, -0 lines 0 comments Download
Modules/_multiprocessing/socket_connection.c View 1 chunk +180 lines, -0 lines 0 comments Download
Modules/_multiprocessing/win32_functions.c View 1 chunk +260 lines, -0 lines 0 comments Download
setup.py View 1 chunk +54 lines, -0 lines 2 comments Download

Messages

Total messages: 3
Georg
http://codereview.appspot.com/2061/diff/1/21 File setup.py (right): http://codereview.appspot.com/2061/diff/1/21#newcode1285 Line 1285: mmacros = [(k, v) for k, v in ...
13 years, 3 months ago (2008-06-10 19:23:57 UTC) #1
jnoller
http://codereview.appspot.com/2061/diff/1/21 File setup.py (right): http://codereview.appspot.com/2061/diff/1/21#newcode1285 Line 1285: mmacros = [(k, v) for k, v in ...
13 years, 3 months ago (2008-06-10 19:35:26 UTC) #2
Benjamin
13 years, 3 months ago (2008-06-10 20:50:51 UTC) #3
I gave everything a quick look over. Overall, the code is well-commented and
clean. I didn't find anything serious. Mostly I just made suggestions. If you
only need it to run on 2.6, I can make a bunch of suggestions (like using
str.format). If you don't, that's fine too.

Thanks very much.

http://codereview.appspot.com/2061/diff/1/39
File Lib/multiprocessing/__init__.py (right):

http://codereview.appspot.com/2061/diff/1/39#newcode53
Line 53: 
Would you like to add __author__?

http://codereview.appspot.com/2061/diff/1/39#newcode62
Line 62: from multiprocessing.process import Process, current_process,
active_children
Do you want to use relative imports?

http://codereview.appspot.com/2061/diff/1/40
File Lib/multiprocessing/connection.py (right):

http://codereview.appspot.com/2061/diff/1/40#newcode31
Line 31: bytes = str                  # XXX not needed in 2.6 and 3.0
Can this go or do you want to maintain backwards-compatibility?

http://codereview.appspot.com/2061/diff/1/38
File Lib/multiprocessing/sharedctypes.py (right):

http://codereview.appspot.com/2061/diff/1/38#newcode69
Line 69: lock = kwds.pop('lock', None)
In Py3k, lock can become a keyword-only argument for real.

http://codereview.appspot.com/2061/diff/1/32
File Lib/multiprocessing/synchronize.py (right):

http://codereview.appspot.com/2061/diff/1/32#newcode112
Line 112: if threading.currentThread().getName() != 'MainThread':
Once I get the new threading API checked in, it can be used.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b