http://codereview.appspot.com/206099/diff/1/2 File Core-Gadget.xml (right): http://codereview.appspot.com/206099/diff/1/2#newcode1739 Core-Gadget.xml:1739: <t>Description: Retrieves a preference as an array of Strings. ...
14 years, 2 months ago
(2010-02-16 17:17:56 UTC)
#1
http://codereview.appspot.com/206099/diff/1/2
File Core-Gadget.xml (right):
http://codereview.appspot.com/206099/diff/1/2#newcode1739
Core-Gadget.xml:1739: <t>Description: Retrieves a preference as an array of
Strings. The string elements in the array are returned as-is and MUST not be
escaped or modified from values set using setArray. Arrays are converted to and
from strings. Array elements are delimited using the pipe character. All
occurrences of the pipe character "|" within each element MUST be
escaped/unescaped when converting to/from a string.</t>
I think you can drop the sentence "Arrays are converted to and from strings."
http://codereview.appspot.com/206099/diff/1/2 File Core-Gadget.xml (right): http://codereview.appspot.com/206099/diff/1/2#newcode1882 Core-Gadget.xml:1882: <t>Description: Retrieves a preference as a string. The value ...
14 years, 2 months ago
(2010-02-18 00:57:46 UTC)
#2
http://codereview.appspot.com/206099/diff/1/2
File Core-Gadget.xml (right):
http://codereview.appspot.com/206099/diff/1/2#newcode1882
Core-Gadget.xml:1882: <t>Description: Retrieves a preference as a string. The
value is returned as-is and MUST not be escaped or modified from the declared or
set value.</t>
Shindig currently does escape return values, which is annoying, but if we change
it now, it will break a bunch of existing implementations and could create
security holes in gadgets that assume escaping.
Issue 206099: Proposed text for getArray and getString
Created 14 years, 2 months ago by Mark W.
Modified 9 years, 4 months ago
Reviewers: Lane LiaBraaten, Tim Moore
Base URL: http://opensocial-resources.googlecode.com/svn/spec/draft/
Comments: 2