Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1514)

Issue 206099: Proposed text for getArray and getString

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 2 months ago by Mark W.
Modified:
9 years, 4 months ago
Base URL:
http://opensocial-resources.googlecode.com/svn/spec/draft/
Visibility:
Public.

Description

The Core-Gadet specification should have more precision around the behavior for getArray and setString.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M Core-Gadget.xml View 2 chunks +2 lines, -3 lines 2 comments Download

Messages

Total messages: 2
Lane LiaBraaten
http://codereview.appspot.com/206099/diff/1/2 File Core-Gadget.xml (right): http://codereview.appspot.com/206099/diff/1/2#newcode1739 Core-Gadget.xml:1739: <t>Description: Retrieves a preference as an array of Strings. ...
14 years, 2 months ago (2010-02-16 17:17:56 UTC) #1
Tim Moore
14 years, 2 months ago (2010-02-18 00:57:46 UTC) #2
http://codereview.appspot.com/206099/diff/1/2
File Core-Gadget.xml (right):

http://codereview.appspot.com/206099/diff/1/2#newcode1882
Core-Gadget.xml:1882: <t>Description: Retrieves a preference as a string. The
value is returned as-is and MUST not be escaped or modified from the declared or
set value.</t>
Shindig currently does escape return values, which is annoying, but if we change
it now, it will break a bunch of existing implementations and could create
security holes in gadgets that assume escaping.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b