Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2169)

Issue 206092: Fix issue 1011.

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 2 months ago by chhitz
Modified:
9 years, 4 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix issue 1011. Make lilypond-book handle spaces before the closing '>' bracket as allowed by the HTML standard. Add regression tests for issue 1011. Checks if lilypond-book works with spaces and newlines in front of the closing '>' bracket. Add regression tests for lilypond-book. Test the operation of lilypond-book with HTML files.

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -4 lines) Patch
M GNUmakefile.in View 2 chunks +2 lines, -0 lines 0 comments Download
M input/regression/GNUmakefile View 1 chunk +1 line, -1 line 1 comment Download
A input/regression/lilypondbook_html/GNUmakefile View 1 chunk +15 lines, -0 lines 2 comments Download
A input/regression/lilypondbook_html/basic.lyhtml View 1 chunk +7 lines, -0 lines 0 comments Download
A input/regression/lilypondbook_html/include.ly View 1 chunk +3 lines, -0 lines 0 comments Download
A input/regression/lilypondbook_html/include_space_after_tag.lyhtml View 1 chunk +8 lines, -0 lines 0 comments Download
A input/regression/lilypondbook_html/inline.lyhtml View 1 chunk +4 lines, -0 lines 0 comments Download
A input/regression/lilypondbook_html/inline_newline_after_tag.lyhtml View 1 chunk +6 lines, -0 lines 0 comments Download
A input/regression/lilypondbook_html/newline_after_tag.lyhtml View 1 chunk +9 lines, -0 lines 0 comments Download
A input/regression/lilypondbook_html/space_after_tag.lyhtml View 1 chunk +7 lines, -0 lines 0 comments Download
A make/lilypondbook_html-rules.make View 1 chunk +4 lines, -0 lines 0 comments Download
A make/lilypondbook_html-targets.make View 1 chunk +1 line, -0 lines 0 comments Download
A make/lilypondbook_html-vars.make View 1 chunk +7 lines, -0 lines 0 comments Download
M scripts/build/lys-to-tely.py View 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/lilypond-book.py View 3 chunks +3 lines, -3 lines 1 comment Download

Messages

Total messages: 1
Graham Percival (old account)
14 years, 2 months ago (2010-02-13 20:40:22 UTC) #1
If John or anybody else wants to set in with comments about the build system,
that would be nice.  I'm really uncertain about having an html-specific regtest
dir; I'd much rather seen a lilypond-book dir that tested all output formats.

http://codereview.appspot.com/206092/diff/1/3
File input/regression/GNUmakefile (right):

http://codereview.appspot.com/206092/diff/1/3#newcode9
input/regression/GNUmakefile:9: SUBDIRS=musicxml abc2ly lilypondbook_html
I guess this is as good a place as any: why is this dir only checking
lilypondbook_html ?  If we're going to have any regtests specifically for
lilypond-book, surely it would be better to test all output formats?

http://codereview.appspot.com/206092/diff/1/4
File input/regression/lilypondbook_html/GNUmakefile (right):

http://codereview.appspot.com/206092/diff/1/4#newcode9
input/regression/lilypondbook_html/GNUmakefile:9: 
I don't understand this part -- why not always set LILYBOOK_HTML_FILES = ""   ?

http://codereview.appspot.com/206092/diff/1/4#newcode12
input/regression/lilypondbook_html/GNUmakefile:12: 
I'd rather not have a TMP variable; could you give it a better name?

http://codereview.appspot.com/206092/diff/1/16
File scripts/lilypond-book.py (right):

http://codereview.appspot.com/206092/diff/1/16#newcode396
scripts/lilypond-book.py:396: 
The changes to this file have been accepted and pushed, thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b