Issue 20580043: code review 20580043: [release-branch.go1.2] crypto/x509: name constraints sh...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 20580043: code review 20580043: [release-branch.go1.2] crypto/x509: name constraints sh... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by adg

Modified:
11 years, 4 months ago

Reviewers:
dsymonds

CC:
golang-dev

Visibility:
Public.

Description

[release-branch.go1.2] crypto/x509: name constraints should be a disjunction. ««« CL 15570044 / b4c37131e846 crypto/x509: name constraints should be a disjunction. The code was requiring that all constraints be met, but it should be satisfied by meeting *any* of them. R=golang-dev, bradfitz, r CC=golang-dev https://codereview.appspot.com/15570044 »»»

Patch Set 1 #

Patch Set 2 : diff -r d89d72656f60 https://code.google.com/p/go #

Patch Set 3 : diff -r d89d72656f60 https://code.google.com/p/go #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+188 lines, -1 line)			Patch
	M	src/pkg/crypto/x509/verify.go	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
	M	src/pkg/crypto/x509/verify_test.go	View	1	2 chunks	+183 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 4 months ago (2013-11-01 00:09:39 UTC) #1

adg

*** Submitted as https://code.google.com/p/go/source/detail?r=f3e0f802d05a *** [release-branch.go1.2] crypto/x509: name constraints should be a disjunction. ««« CL ...

11 years, 4 months ago (2013-11-01 00:10:06 UTC) #2

LGTM

Expand All Messages | Collapse All Messages