Session hash implementation (WIP)

Wan-Teh, can you see this?

[ekr-rietveld, 2015-02-09 04:25:14]

Self-review

https://codereview.appspot.com/204760043/diff/1/cmd/selfserv/selfserv.c
File cmd/selfserv/selfserv.c (right):

https://codereview.appspot.com/204760043/diff/1/cmd/selfserv/selfserv.c#newco...
cmd/selfserv/selfserv.c:2192:
"2:A:BC:DEGL:M:NP:RST:V:Ya:bc:d:e:f:g:hi:jk:lmn:op:qrst:uvw:xyz");
Remove S

https://codereview.appspot.com/204760043/diff/1/cmd/tstclnt/tstclnt.c
File cmd/tstclnt/tstclnt.c (right):

https://codereview.appspot.com/204760043/diff/1/cmd/tstclnt/tstclnt.c#newcode813
cmd/tstclnt/tstclnt.c:813: int                enableExtendedMasterSecret = 0;
PRBool

https://codereview.appspot.com/204760043/diff/1/external_tests/ssl_gtest/ssl_...
File external_tests/ssl_gtest/ssl_loopback_unittest.cc (right):

https://codereview.appspot.com/204760043/diff/1/external_tests/ssl_gtest/ssl_...
external_tests/ssl_gtest/ssl_loopback_unittest.cc:380: 
Whitespace only change.

https://codereview.appspot.com/204760043/diff/1/external_tests/ssl_gtest/ssl_...
external_tests/ssl_gtest/ssl_loopback_unittest.cc:446: std::cerr << "Checking
extended master secret for " << name_ << " expected=" << expected << std::endl;
Break this line

https://codereview.appspot.com/204760043/diff/1/external_tests/ssl_gtest/ssl_...
external_tests/ssl_gtest/ssl_loopback_unittest.cc:638: void
ExpectExtendedMasterSecret(bool expected) {
This hack isn't needed any more.

https://codereview.appspot.com/204760043/diff/1/lib/ssl/ssl3con.c
File lib/ssl/ssl3con.c (right):

https://codereview.appspot.com/204760043/diff/1/lib/ssl/ssl3con.c#newcode3607
lib/ssl/ssl3con.c:3607: /* Go through the normal setup but then generate the
random
s/the/a/

https://codereview.appspot.com/204760043/diff/1/lib/ssl/ssl3con.c#newcode3681
lib/ssl/ssl3con.c:3681: PORT_Assert(!pwSpec->master_secret);
This needs a double-check with WTC.

https://codereview.appspot.com/204760043/diff/1/lib/ssl/ssl3con.c#newcode6499
lib/ssl/ssl3con.c:6499: if (sid->u.ssl3.extendedMasterSecretUsed &&
Add a comment.

https://codereview.appspot.com/204760043/diff/1/lib/ssl/ssl3con.c#newcode8237
lib/ssl/ssl3con.c:8237: 
Whitespace only change.

https://codereview.appspot.com/204760043/diff/1/lib/ssl/ssl3ext.c
File lib/ssl/ssl3ext.c (right):

https://codereview.appspot.com/204760043/diff/1/lib/ssl/ssl3ext.c#newcode92
lib/ssl/ssl3ext.c:92: SECItem *data);
Fix indent.

https://codereview.appspot.com/204760043/diff/1/lib/ssl/ssl3ext.c#newcode2602
lib/ssl/ssl3ext.c:2602: return SECSuccess;  /* TODO(ekr@rtfm.com): should this
be SECFailure? */
SECFailure

https://codereview.appspot.com/204760043/diff/1/lib/ssl/sslt.h
File lib/ssl/sslt.h (right):

https://codereview.appspot.com/204760043/diff/1/lib/ssl/sslt.h#newcode126
lib/ssl/sslt.h:126: /* The following fields are added in NSS TODO */
VErsion XXX

[wtc, 2015-03-03 20:16:40]

Eric, yes, I can see this CL now. Thanks.

[ekr-rietveld, 2015-03-03 20:32:05]

Note: do not review the PKCS#11 changes, which are part of Richard Barnes's
patch.

[ekr-rietveld, 2015-03-04 01:56:39]

Please also ignore the tests. I had to rebase on top of MT's patch, so I will be
generating a new patch that is just the deltas from those tests, but until then
it's hard to make sense of this.

https://codereview.appspot.com/210160043/

[wtc1, 2015-04-07 18:48:20]

Hi Eric,

Should this CL be closed in favor of https://codereview.appspot.com/211900043/?