Issue 20410043: Adds basket name to bundle token title

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 20410043: Adds basket name to bundle token title

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by jeff.pihach

Modified:
10 years, 6 months ago

Reviewers:
mp+193478, matthew.scott, gary.poster

Visibility:
Public.

Description

Adds basket name to bundle token title https://code.launchpad.net/~hatch/juju-gui/bundle-label-1246462/+merge/193478 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Adds basket name to bundle token title #

Patch Set 3 : Adds basket name to bundle token title #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/templates/bundle-token.handlebars	View		1 chunk	+1 line, -1 line	0 comments	Download
M	app/widgets/token.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/views/browser/main.less	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gary.poster

LGTM. QAOK if we can increase max-width of #subapp-browser #bws-sidebar .bws-content .yui3-token .title to 170px ...

10 years, 6 months ago (2013-10-31 19:14:21 UTC) #3

jeff.pihach

Thanks for the reviews! token title width was increased to 170, it looks much better.

10 years, 6 months ago (2013-10-31 19:18:50 UTC) #4

jeff.pihach

10 years, 6 months ago (2013-10-31 20:17:02 UTC) #5

*** Submitted:

Adds basket name to bundle token title

R=matthew.scott, gary.poster
CC=
https://codereview.appspot.com/20410043

Expand All Messages | Collapse All Messages