Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1132)

Issue 20370043: Honor the options type when exporting bundles.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by frankban
Modified:
10 years, 6 months ago
Reviewers:
gary.poster, mp+193464
Visibility:
Public.

Description

Honor the options type when exporting bundles. Improve the way booleans, int and float service options are exported in the bundle. Also fix a bug with boolean options and checkboxes in the inspector: - set an option to true and save; - restore an option to false and save; - the option label says "false" but the checkbox is switched back to true. We might need to improve the way boolean options are normalized before they are stored in the db. They can be booleans or strings, I guess based on the code path that executes the service.set('config') call. Added an XXX comment. QA: - try what described above in the inspector; - set/unset/restore to default options, including booleans, integers/floats and strings; export the bundle; ensure it works. https://code.launchpad.net/~frankban/juju-gui/export-types/+merge/193464 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -9 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/models/models.js View 1 chunk +23 lines, -5 lines 0 comments Download
M app/views/viewlets/service-config.js View 2 chunks +7 lines, -4 lines 0 comments Download
M test/test_model.js View 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 4
frankban
Please take a look.
10 years, 6 months ago (2013-10-31 17:49:11 UTC) #1
gary.poster
LGTM. Qa-ing now
10 years, 6 months ago (2013-10-31 18:00:19 UTC) #2
gary.poster
On 2013/10/31 18:00:19, gary.poster wrote: > LGTM. Qa-ing now Bah. QA was good but I ...
10 years, 6 months ago (2013-11-01 00:16:48 UTC) #3
gary.poster
10 years, 6 months ago (2013-11-01 00:22:29 UTC) #4
*** Submitted:

Honor the options type when exporting bundles.

Improve the way booleans, int and float 
service options are exported in the bundle.

Also fix a bug with boolean options and
checkboxes in the inspector:
- set an option to true and save;
- restore an option to false and save;
- the option label says "false" but
  the checkbox is switched back to true.

We might need to improve the way boolean options 
are normalized before they are stored in the db. 
They can be booleans or strings, I guess based 
on the code path that executes the 
service.set('config') call. Added an XXX comment.

QA: 
- try what described above in the inspector;
- set/unset/restore to default options,
  including booleans, integers/floats and 
  strings; export the bundle; ensure it works.

R=gary.poster
CC=
https://codereview.appspot.com/20370043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b