Issue 202990043: code review 202990043: snappy: add Reset methods to Reader and Writer.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 202990043: code review 202990043: snappy: add Reset methods to Reader and Writer. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by nigeltao

Modified:
9 years, 10 months ago

Reviewers:
bradfitz

CC:
bradfitz, golang-codereviews

Visibility:
Public.

Description

snappy: add Reset methods to Reader and Writer.

Patch Set 2 : diff -r 780a37fbd5b6057a94e192749979c09bfa651f55 https://code.google.com/p/snappy-go #

Patch Set 3 : diff -r 780a37fbd5b6057a94e192749979c09bfa651f55 https://code.google.com/p/snappy-go #

Total comments: 2

Patch Set 4 : diff -r 780a37fbd5b6057a94e192749979c09bfa651f55 https://code.google.com/p/snappy-go #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -18 lines)			Patch
M	snappy/decode.go	View	1 2 3	3 chunks	+18 lines, -5 lines	0 comments	Download
M	snappy/encode.go	View	1 2 3	2 chunks	+14 lines, -4 lines	0 comments	Download
M	snappy/snappy_test.go	View	1	2 chunks	+83 lines, -9 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello bradfitz@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/snappy-go

9 years, 10 months ago (2015-02-10 02:26:37 UTC) #1

bradfitz

LGTM https://codereview.appspot.com/202990043/diff/40001/snappy/decode.go File snappy/decode.go (right): https://codereview.appspot.com/202990043/diff/40001/snappy/decode.go#newcode142 snappy/decode.go:142: type Reader struct { doc comment https://codereview.appspot.com/202990043/diff/40001/snappy/encode.go File ...

9 years, 10 months ago (2015-02-10 02:28:45 UTC) #2

nigeltao

9 years, 10 months ago (2015-02-10 03:07:21 UTC) #3

*** Submitted as
https://code.google.com/p/snappy-go/source/detail?r=71e98457a443 ***

snappy: add Reset methods to Reader and Writer.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://codereview.appspot.com/202990043

Expand All Messages | Collapse All Messages