Issue 20290045: code review 20290045: [release-branch.go1.2] misc/dist: build race packages w...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 20290045: code review 20290045: [release-branch.go1.2] misc/dist: build race packages w... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by adg

Modified:
11 years, 4 months ago

Reviewers:
dsymonds

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

[release-branch.go1.2] misc/dist: build race packages when os suffix present ««« CL 14930043 / 5746e3a5443b misc/dist: build race packages when os suffix present The "darwin-amd64-osx10.8" target was not matching "darwin-amd64". R=golang-dev CC=golang-dev https://codereview.appspot.com/14930043 »»»

Patch Set 1 #

Patch Set 2 : diff -r 45475ec7eab1 https://code.google.com/p/go #

Patch Set 3 : diff -r 45475ec7eab1 https://code.google.com/p/go #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	misc/dist/bindist.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 4 months ago (2013-10-31 23:49:19 UTC) #1

adg

11 years, 4 months ago (2013-10-31 23:50:12 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=8f428c6be9fd ***

[release-branch.go1.2] misc/dist: build race packages when os suffix present

««« CL 14930043 / 5746e3a5443b
misc/dist: build race packages when os suffix present

The "darwin-amd64-osx10.8" target was not matching "darwin-amd64".

R=golang-dev
CC=golang-dev
https://codereview.appspot.com/14930043
»»»

R=golang-dev, dsymonds
CC=golang-dev
https://codereview.appspot.com/20290045

Expand All Messages | Collapse All Messages