Issue 20170043: code review 20170043: leveldb: change the table file extension from .sst to ....

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 20170043: code review 20170043: leveldb: change the table file extension from .sst to .... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by nigeltao

Modified:
11 years ago

Reviewers:
adg

CC:
bradfitz, adg, golang-dev

Visibility:
Public.

Description

leveldb: change the table file extension from .sst to .ldb, as per the C++ leveldb project. https://groups.google.com/forum/#!topic/leveldb/u9izbG-pDis

Patch Set 1 #

Patch Set 2 : diff -r d752f26707c7 https://code.google.com/p/leveldb-go #

Patch Set 3 : diff -r d752f26707c7 https://code.google.com/p/leveldb-go #

Patch Set 4 : diff -r d752f26707c7 https://code.google.com/p/leveldb-go #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -7 lines)			Patch
M	leveldb/compaction_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	leveldb/filenames.go	View	1	3 chunks	+6 lines, -1 line	0 comments	Download
M	leveldb/filenames_test.go	View	1	2 chunks	+7 lines, -4 lines	0 comments	Download
M	leveldb/leveldb.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	leveldb/table_cache.go	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/leveldb-go

11 years ago (2013-10-31 06:59:33 UTC) #1

nigeltao

11 years ago (2013-11-01 01:49:08 UTC) #3

*** Submitted as
https://code.google.com/p/leveldb-go/source/detail?r=953ed74bfcc1 ***

leveldb: change the table file extension from .sst to .ldb, as per
the C++ leveldb project.

https://groups.google.com/forum/#!topic/leveldb/u9izbG-pDis

R=bradfitz, adg
CC=golang-dev
https://codereview.appspot.com/20170043

Expand All Messages | Collapse All Messages