Issue 201220043: code review 201220043: snappy: make TestFramingFormat not depend on downloadin...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 201220043: code review 201220043: snappy: make TestFramingFormat not depend on downloadin... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by nigeltao

Modified:
10 years, 5 months ago

Reviewers:
dsymonds

CC:
dsymonds, golang-codereviews

Visibility:
Public.

Description

snappy: make TestFramingFormat not depend on downloading (separately licensed) testdata files. Such files are now only used for benchmarks (they are the same files used by the C++ snappy code).

Patch Set 1 #

Patch Set 2 : diff -r 5efa197119d06aa4ee529e6179431293975c77bb https://code.google.com/p/snappy-go #

Patch Set 3 : diff -r 5efa197119d06aa4ee529e6179431293975c77bb https://code.google.com/p/snappy-go #

Patch Set 4 : diff -r 5efa197119d06aa4ee529e6179431293975c77bb https://code.google.com/p/snappy-go #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -20 lines)			Patch
	M	snappy/snappy_test.go	View	1	2 chunks	+28 lines, -20 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello dsymonds@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/snappy-go

10 years, 5 months ago (2015-02-10 04:20:22 UTC) #1

nigeltao

10 years, 5 months ago (2015-02-10 04:23:48 UTC) #3

*** Submitted as
https://code.google.com/p/snappy-go/source/detail?r=8850bd446ad6 ***

snappy: make TestFramingFormat not depend on downloading (separately
licensed) testdata files.

Such files are now only used for benchmarks (they are the same files used
by the C++ snappy code).

LGTM=dsymonds
R=dsymonds
CC=golang-codereviews
https://codereview.appspot.com/201220043

Expand All Messages | Collapse All Messages