Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(444)

Issue 2011047: PHP: gadgets.util.sanitizeHtml does not work anymore

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by bashofmann
Modified:
13 years, 8 months ago
Reviewers:
Paul Lindner
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

Currently the workaround (see https://issues.apache.org/jira/browse/SHINDIG-346?focusedCommentId=12730591&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12730591) to make gadgets.util.sanitizeHtml work in PHP (the Caja Maven dependency is not available and the res:// links in the feature registry do not work therefor) does not work anymore because the linked html-sanitizer.js from the Caja trunk depends on the html4 package now. This dependency is only resolved after building the minified JS files. In order to fix this issue I built the files linked in the feature registry and put them under php/external/resources/. The PHP GadgetFeatureRegistry now resolves all res:// links to be included through a child class of the FilesServlet which then loads the correct file out of the external package.

Patch Set 1 #

Patch Set 2 : just saw, that i had forgotten one hardcoded URL in the GadgetFeatureRegistry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2957 lines, -36 lines) Patch
php/NOTICE View 1 chunk +3 lines, -0 lines 0 comments Download
php/config/container.php View 2 chunks +4 lines, -2 lines 0 comments Download
php/config/container.php View 2 chunks +4 lines, -2 lines 0 comments Download
php/external/resources/com/google/caja/plugin/domita-minified.js View 1 chunk +768 lines, -0 lines 0 comments Download
php/external/resources/com/google/caja/plugin/domita-minified.js View 1 chunk +768 lines, -0 lines 0 comments Download
php/external/resources/com/google/caja/plugin/html-sanitizer-minified.js View 1 chunk +45 lines, -0 lines 0 comments Download
php/external/resources/com/google/caja/plugin/html-sanitizer-minified.js View 1 chunk +45 lines, -0 lines 0 comments Download
php/external/resources/com/google/caja/plugin/valija.out.js View 1 chunk +453 lines, -0 lines 0 comments Download
php/external/resources/com/google/caja/plugin/valija.out.js View 1 chunk +453 lines, -0 lines 0 comments Download
php/src/gadgets/GadgetFeatureRegistry.php View 3 chunks +25 lines, -10 lines 0 comments Download
php/src/gadgets/GadgetFeatureRegistry.php View 1 1 chunk +23 lines, -12 lines 0 comments Download
php/src/gadgets/servlet/ContentFilesServlet.php View 1 chunk +26 lines, -0 lines 0 comments Download
php/src/gadgets/servlet/ContentFilesServlet.php View 1 1 chunk +26 lines, -0 lines 0 comments Download
php/src/gadgets/servlet/FilesServlet.php View 2 chunks +16 lines, -4 lines 0 comments Download
php/src/gadgets/servlet/FilesServlet.php View 2 chunks +16 lines, -4 lines 0 comments Download
php/src/gadgets/servlet/ResourcesFilesServlet.php View 1 chunk +33 lines, -0 lines 0 comments Download
php/src/gadgets/servlet/ResourcesFilesServlet.php View 1 1 chunk +33 lines, -0 lines 0 comments Download
php/test/ShindigAllTests.php View 1 chunk +1 line, -1 line 0 comments Download
php/test/ShindigAllTests.php View 1 chunk +1 line, -1 line 0 comments Download
php/test/gadgets/FilesServletTest.php View 1 chunk +107 lines, -0 lines 0 comments Download
php/test/gadgets/FilesServletTest.php View 1 chunk +107 lines, -0 lines 0 comments Download

Messages

Total messages: 3
bashofmann
13 years, 8 months ago (2010-08-24 11:46:32 UTC) #1
Paul Lindner
Looks good, I'd add caja to the php/NOTICE and /NOTICE files to indicate that we're ...
13 years, 8 months ago (2010-08-24 14:35:57 UTC) #2
bashofmann
13 years, 8 months ago (2010-08-24 15:29:55 UTC) #3
just saw, that i had forgotten one hardcoded URL in the GadgetFeatureRegistry
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b