Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7713)

Issue 20110044: Laplacian Deform with no bmesh

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by howardt
Modified:
10 years, 5 months ago
Reviewers:
ideasman42, howardt
CC:
apinzonf
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

Laplacian Deform with no bmesh

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+936 lines, -0 lines) Patch
M release/scripts/startup/bl_ui/properties_data_modifier.py View 1 chunk +5 lines, -0 lines 0 comments Download
M source/blender/blenloader/intern/readfile.c View 1 chunk +9 lines, -0 lines 0 comments Download
M source/blender/blenloader/intern/writefile.c View 1 chunk +5 lines, -0 lines 0 comments Download
M source/blender/makesdna/DNA_modifier_types.h View 2 chunks +10 lines, -0 lines 0 comments Download
M source/blender/makesrna/RNA_access.h View 1 chunk +1 line, -0 lines 0 comments Download
M source/blender/makesrna/intern/rna_modifier.c View 5 chunks +38 lines, -0 lines 0 comments Download
M source/blender/modifiers/CMakeLists.txt View 1 chunk +1 line, -0 lines 0 comments Download
M source/blender/modifiers/MOD_modifiertypes.h View 1 chunk +1 line, -0 lines 0 comments Download
A source/blender/modifiers/intern/MOD_laplaciandeform.c View 1 chunk +865 lines, -0 lines 1 comment Download
M source/blender/modifiers/intern/MOD_util.c View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1
ideasman42
10 years, 5 months ago (2013-11-05 12:22:57 UTC) #1
I've made some cleanup commits to svn, and think this is very close to being
ready for trunk.

However I found a bug- which is really an error in the way meshes and derived
mesh is handled. - see inline comment.

https://codereview.appspot.com/20110044/diff/1/source/blender/modifiers/inter...
File source/blender/modifiers/intern/MOD_laplaciandeform.c (right):

https://codereview.appspot.com/20110044/diff/1/source/blender/modifiers/inter...
source/blender/modifiers/intern/MOD_laplaciandeform.c:643: me = ob->data;
I think this cant work.

Mixing original mesh indicies with the derived meshes is quite risky and I'd
advise against it.

For example, its possible the original mesh has no faces, but the derived mesh
does.

I created such an example and it crashes. (select a vertex group and change the
iteration option).

http://www.graphicall.org/ftp/ideasman42/deform_mod_crash.blend

So AFAICS theres no need to depend on the original mesh, just use the derived
mesh.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b