I've made some cleanup commits to svn, and think this is very close to being ...
10 years, 5 months ago
(2013-11-05 12:22:57 UTC)
#1
I've made some cleanup commits to svn, and think this is very close to being
ready for trunk.
However I found a bug- which is really an error in the way meshes and derived
mesh is handled. - see inline comment.
https://codereview.appspot.com/20110044/diff/1/source/blender/modifiers/inter...
File source/blender/modifiers/intern/MOD_laplaciandeform.c (right):
https://codereview.appspot.com/20110044/diff/1/source/blender/modifiers/inter...
source/blender/modifiers/intern/MOD_laplaciandeform.c:643: me = ob->data;
I think this cant work.
Mixing original mesh indicies with the derived meshes is quite risky and I'd
advise against it.
For example, its possible the original mesh has no faces, but the derived mesh
does.
I created such an example and it crashes. (select a vertex group and change the
iteration option).
http://www.graphicall.org/ftp/ideasman42/deform_mod_crash.blend
So AFAICS theres no need to depend on the original mesh, just use the derived
mesh.
Issue 20110044: Laplacian Deform with no bmesh
Created 10 years, 6 months ago by howardt
Modified 10 years, 5 months ago
Reviewers: ideasman42, howardt
Base URL: https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Comments: 1