Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Issue 1995045: Recognize arguments.callee in valija mode. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 10 months ago by MikeSamuel
Modified:
13 years, 7 months ago
Reviewers:
MarkM, Jasvir, metaweta
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Adds a valija rewriting rule that recognizes arguments.callee and translates it into the expression $caja$self and adds the necessary definition to the top of functions that mention $caja$self. This is for backwards compatibility with code in jquery/sizzle that uses arguments.callee extensively.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -42 lines) Patch
M src/com/google/caja/parser/quasiliteral/DefaultValijaRewriter.java View 10 chunks +49 lines, -15 lines 1 comment Download
M src/com/google/caja/parser/quasiliteral/Scope.java View 6 chunks +28 lines, -2 lines 0 comments Download
M tests/com/google/caja/opensocial/example-rewritten.xml View 1 chunk +1 line, -2 lines 0 comments Download
M tests/com/google/caja/parser/quasiliteral/CajitaRewriterTest.java View 1 chunk +14 lines, -0 lines 0 comments Download
M tests/com/google/caja/parser/quasiliteral/CommonJsRewriterTestCase.java View 6 chunks +5 lines, -17 lines 0 comments Download
M tests/com/google/caja/parser/quasiliteral/DefaultValijaRewriterTest.java View 4 chunks +25 lines, -6 lines 0 comments Download

Messages

Total messages: 14
MikeSamuel
15 years, 10 months ago (2010-08-17 22:44:28 UTC) #1
MarkM
I'm sorry, but my inclination is to -1 this whole CL. I think it's a ...
15 years, 10 months ago (2010-08-18 02:26:23 UTC) #2
MarkM
On 2010/08/18 02:26:23, MarkM wrote: > a.foo() ==== a.foo.call(a) // assuming call wasn't overridden This ...
15 years, 10 months ago (2010-08-18 02:30:07 UTC) #3
MikeSamuel
I filed http://dev.jquery.com/ticket/6917 Hopefully the jquery guys are receptive. 2010/8/17 <erights@gmail.com>: > On 2010/08/18 02:26:23, ...
15 years, 10 months ago (2010-08-19 00:28:34 UTC) #4
metaweta
On 2010/08/19 00:28:34, MikeSamuel wrote: > I filed http://dev.jquery.com/ticket/6917 > Hopefully the jquery guys are ...
14 years, 10 months ago (2011-08-22 16:39:51 UTC) #5
metaweta
On 2011/08/22 16:39:51, metaweta wrote: > On 2010/08/19 00:28:34, MikeSamuel wrote: > > I filed ...
14 years, 6 months ago (2011-12-16 17:38:07 UTC) #6
metaweta
On 2011/12/16 17:38:07, metaweta wrote: > Please close this review. Ping
14 years, 4 months ago (2012-02-20 19:02:24 UTC) #7
metaweta
On 2012/02/20 19:02:24, metaweta wrote: > On 2011/12/16 17:38:07, metaweta wrote: > > Please close ...
14 years, 3 months ago (2012-02-28 20:33:42 UTC) #8
metaweta
On 2012/02/28 20:33:42, metaweta wrote: > On 2012/02/20 19:02:24, metaweta wrote: > > On 2011/12/16 ...
14 years, 3 months ago (2012-03-27 00:05:45 UTC) #9
metaweta
On 2012/03/27 00:05:45, metaweta wrote: > On 2012/02/28 20:33:42, metaweta wrote: > > On 2012/02/20 ...
14 years, 1 month ago (2012-05-08 21:30:32 UTC) #10
metaweta
On 2012/05/08 21:30:32, metaweta wrote: > On 2012/03/27 00:05:45, metaweta wrote: > > On 2012/02/28 ...
13 years, 9 months ago (2012-09-06 17:58:00 UTC) #11
metaweta
I cast "Turn Undead".
13 years, 8 months ago (2012-10-09 20:13:21 UTC) #12
metaweta
Die Liste der Änderungen, Die! -- Sideshow Bob.
13 years, 8 months ago (2012-10-23 20:23:11 UTC) #13
metaweta
13 years, 8 months ago (2012-10-29 19:46:20 UTC) #14
Valija is dead.  Long live ES5/3!
(Well, actually, may ES5/3 die quickly and allow SES to take the throne!)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b