Recognize arguments.callee in valija mode.

Adds a valija rewriting rule that recognizes arguments.callee and
translates it into the expression $caja$self and adds the necessary
definition to the top of functions that mention $caja$self.

This is for backwards compatibility with code in jquery/sizzle that
uses arguments.callee extensively.

[MarkM, 2010-08-18 02:26:23]

I'm sorry, but my inclination is to -1 this whole CL. I think it's a bad idea.

* Both Cajita and Valija are supposed to be subsets of ES5/strict. In
ES5/strict, 'arguments.callee' fails.

* jquery's src/ contains no occurrences of 'arguments.callee'. All occurrences
occur only in the speed/ and test/ directories. There are 16 in all, and all are
easily fixed.

* Since these changes to speed/ and test/ are needed anyway to make jquery
compatible with ES5/strict, we have a good chance of getting them accepted back
into jquery. And even if we don't, we're free to fork and serve (eventually from
our cdn) the cajoling of our version as the cajoled jquery.

* We need to make these changes to jquery anyway for compat with ES5/3 and SES.

* ES5/strict and history aside, the suggested change makes the Valija language
even more bizarre than JS. With "====" meaning "equivalent", it breaks the
following equivalences (order of side effects aside) that currently hold in JS:

    a['foo'] ==== a.foo
    a.foo() ==== a.foo.call(a) // assuming call wasn't overridden
    (1,a).foo ==== a.foo

These were off the top of my head. I'm sure I could generate more.


As a temporary development time kludge to get jquery cajoling earlier, I would
have no problem seeing this in an experimental branch. But not in
non-experimental trunk.

http://codereview.appspot.com/1995045/diff/1/6
File src/com/google/caja/parser/quasiliteral/DefaultValijaRewriter.java (right):

http://codereview.appspot.com/1995045/diff/1/6#newcode78
src/com/google/caja/parser/quasiliteral/DefaultValijaRewriter.java:78: if
(scope.hasFreeArgumentsCallee()) {
Since this test can only pass when the broader hasFreeArguments() test passes,
you could put this inside the consequent of the previous if, saving a few
cycles.

[MarkM, 2010-08-18 02:30:07]

On 2010/08/18 02:26:23, MarkM wrote:
>     a.foo() ==== a.foo.call(a) // assuming call wasn't overridden

This got me curious. An interesting test case:

  function foo() {
    if (this !== window) { return this; } 
    return arguments.callee(); 
  }
  foo(4,5,6).length; // returns 3

So calling 'arguments.callee' as a method really does bind the arguments object
to the callee's "this" as it should.

[MikeSamuel, 2010-08-19 00:28:34]

I filed http://dev.jquery.com/ticket/6917
Hopefully the jquery guys are receptive.

2010/8/17  <erights@gmail.com>:
> On 2010/08/18 02:26:23, MarkM wrote:
>>
>>     a.foo() ==== a.foo.call(a) // assuming call wasn't overridden
>
> This got me curious. An interesting test case:
>
>  function foo() {
>    if (this !== window) { return this; }
>    return arguments.callee();
>  }
>  foo(4,5,6).length; // returns 3
>
> So calling 'arguments.callee' as a method really does bind the arguments
> object to the callee's "this" as it should.
>
> http://codereview.appspot.com/1995045/
>

[metaweta, 2011-08-22 16:39:51]

On 2010/08/19 00:28:34, MikeSamuel wrote:
> I filed http://dev.jquery.com/ticket/6917
> Hopefully the jquery guys are receptive.
> 
> 2010/8/17  <erights@gmail.com>:
> > On 2010/08/18 02:26:23, MarkM wrote:
> >>
> >> &nbsp; &nbsp; a.foo() ==== a.foo.call(a) // assuming call wasn't overridden
> >
> > This got me curious. An interesting test case:
> >
> > &nbsp;function foo() {
> > &nbsp; &nbsp;if (this !== window) { return this; }
> > &nbsp; &nbsp;return arguments.callee();
> > &nbsp;}
> > &nbsp;foo(4,5,6).length; // returns 3
> >
> > So calling 'arguments.callee' as a method really does bind the arguments
> > object to the callee's "this" as it should.
> >
> > http://codereview.appspot.com/1995045/
> >

What's the status of this CL?

[metaweta, 2011-12-16 17:38:07]

On 2011/08/22 16:39:51, metaweta wrote:
> On 2010/08/19 00:28:34, MikeSamuel wrote:
> > I filed http://dev.jquery.com/ticket/6917
> > Hopefully the jquery guys are receptive.
> > 
> > 2010/8/17  <erights@gmail.com>:
> > > On 2010/08/18 02:26:23, MarkM wrote:
> > >>
> > >> &nbsp; &nbsp; a.foo() ==== a.foo.call(a) // assuming call wasn't
overridden
> > >
> > > This got me curious. An interesting test case:
> > >
> > > &nbsp;function foo() {
> > > &nbsp; &nbsp;if (this !== window) { return this; }
> > > &nbsp; &nbsp;return arguments.callee();
> > > &nbsp;}
> > > &nbsp;foo(4,5,6).length; // returns 3
> > >
> > > So calling 'arguments.callee' as a method really does bind the arguments
> > > object to the callee's "this" as it should.
> > >
> > > http://codereview.appspot.com/1995045/
> > >
> 
> What's the status of this CL?

Please close this review.

[metaweta, 2012-02-20 19:02:24]

On 2011/12/16 17:38:07, metaweta wrote:
> Please close this review.

Ping

[metaweta, 2012-02-28 20:33:42]

On 2012/02/20 19:02:24, metaweta wrote:
> On 2011/12/16 17:38:07, metaweta wrote:
> > Please close this review.
> 
> Ping

ping

[metaweta, 2012-03-27 00:05:45]

On 2012/02/28 20:33:42, metaweta wrote:
> On 2012/02/20 19:02:24, metaweta wrote:
> > On 2011/12/16 17:38:07, metaweta wrote:
> > > Please close this review.
> > 
> > Ping
> 
> ping

ping

[metaweta, 2012-05-08 21:30:32]

On 2012/03/27 00:05:45, metaweta wrote:
> On 2012/02/28 20:33:42, metaweta wrote:
> > On 2012/02/20 19:02:24, metaweta wrote:
> > > On 2011/12/16 17:38:07, metaweta wrote:
> > > > Please close this review.
> > > 
> > > Ping
> > 
> > ping
> 
> ping

KILL IT!  KILL IT WITH FIRE!!!

[metaweta, 2012-09-06 17:58:00]

On 2012/05/08 21:30:32, metaweta wrote:
> On 2012/03/27 00:05:45, metaweta wrote:
> > On 2012/02/28 20:33:42, metaweta wrote:
> > > On 2012/02/20 19:02:24, metaweta wrote:
> > > > On 2011/12/16 17:38:07, metaweta wrote:
> > > > > Please close this review.
> > > > 
> > > > Ping
> > > 
> > > ping
> > 
> > ping
> 
> KILL IT!  KILL IT WITH FIRE!!!

For the CL:
Oh how can I miss you, if you won’t go away?
I don’t mean to diss you,
but this is hard to say.
Absence makes the heart grow fonder...
can’t we start today?
But how can I miss you, if you won’t go away?

[metaweta, 2012-10-09 20:13:21]

I cast "Turn Undead".

[metaweta, 2012-10-23 20:23:11]

Die Liste der Änderungen, Die! -- Sideshow Bob.

[metaweta, 2012-10-29 19:46:20]

Valija is dead.  Long live ES5/3!
(Well, actually, may ES5/3 die quickly and allow SES to take the throne!)