Adds highlight to service icon in bundle topo

Adds highlight to service icon in bundle topo

When viewing a bundle topology it will now auto select
a service icon which now adds a highlight svg behind 
the icon and pops open the name panel.

https://code.launchpad.net/~hatch/juju-gui/highlight-bundle-service/+merge/193316

(do not edit description out of merge proposal)

[jeff.pihach, 2013-10-30 19:25:19]

Please take a look.

[jeff.pihach, 2013-10-30 19:31:23]

Please take a look.

[gary.poster, 2013-10-30 20:36:53]

Code LGTM with ultra trivial.  I asked you to investigate using the official
Juju squircle SVG (https://juju.ubuntu.com/docs/media/icon.svg).  I will QA
after you let me know to do so.

https://codereview.appspot.com/19920043/diff/20001/app/views/topology/bundle.js
File app/views/topology/bundle.js (right):

https://codereview.appspot.com/19920043/diff/20001/app/views/topology/bundle....
app/views/topology/bundle.js:140: node.append('image')
I asked on IRC whether we ought to use a ref, but Makyo said it wouldn't buy us
much.  Cool.

https://codereview.appspot.com/19920043/diff/20001/app/views/topology/bundle....
app/views/topology/bundle.js:439: // We need the actual svg dom node out of the
d3 selection
The grammar police! <RRrrrraaaarrrRRRrraaaarrrRRR>

Add a period. ;-)

https://codereview.appspot.com/19920043/diff/20001/app/views/topology/bundle....
app/views/topology/bundle.js:440: // If for whatever reason this node isn't in
the DOM we don't want
The grammar police let the missing comma slide, but they consider a citation.

[gary.poster, 2013-10-30 20:55:40]

QAOK.  Looks great!  Thanks!  I only see aliasing issues with the default icons;
maybe the designers have an idea about that.

[jeff.pihach, 2013-10-30 21:00:43]

Thanks for the review!

https://codereview.appspot.com/19920043/diff/20001/app/views/topology/bundle.js
File app/views/topology/bundle.js (right):

https://codereview.appspot.com/19920043/diff/20001/app/views/topology/bundle....
app/views/topology/bundle.js:439: // We need the actual svg dom node out of the
d3 selection
haha done

https://codereview.appspot.com/19920043/diff/20001/app/views/topology/bundle....
app/views/topology/bundle.js:440: // If for whatever reason this node isn't in
the DOM we don't want
On 2013/10/30 20:36:53, gary.poster wrote:
> The grammar police let the missing comma slide, but they consider a citation.

Done.

[jeff.pihach, 2013-10-30 21:07:57]

*** Submitted:

Adds highlight to service icon in bundle topo

When viewing a bundle topology it will now auto select
a service icon which now adds a highlight svg behind 
the icon and pops open the name panel.

R=gary.poster
CC=
https://codereview.appspot.com/19920043