Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5112)

Issue 199010043: Small style tweaks to charts package that should not have a runtime impact. Make implementation cla…

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 3 months ago by jacobr
Modified:
9 years, 3 months ago
Reviewers:
sigmund
Base URL:
git@github.com:google/charted.git@master
Visibility:
Public.

Description

Small style tweaks to charts package that should not have a runtime impact. Make implementation classes match the type signatures of base classes. Add a few generic types that weren't specified. Cleanup cases where a double was used as an index. Move super calls to end of constructor initialization list matching the Dart style guide. https://www.dartlang.org/articles/style-guide/#do-place-the-super-call-last-in-a-constructor-initialization-list BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -47 lines) Patch
M lib/charts/renderers/stackedbar_chart_renderer.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/charts/renderers/waterfall_chart_renderer.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/charts/src/chart_area_impl.dart View 2 chunks +8 lines, -7 lines 0 comments Download
M lib/charts/src/chart_config_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/charts/src/chart_data_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/charts/transformers/aggregation.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/charts/transformers/aggregation_transformer.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M lib/charts/transformers/transpose_transformer.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/core/core.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/core/lists.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/core/rect.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M lib/locale/number_format.dart View 3 chunks +6 lines, -9 lines 0 comments Download
M lib/locale/time_scale.dart View 2 chunks +7 lines, -4 lines 0 comments Download
M lib/selection/selection_impl.dart View 6 chunks +7 lines, -7 lines 0 comments Download
M lib/svg/svg_line.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1
jacobr
9 years, 3 months ago (2015-01-23 22:22:51 UTC) #1
can you take a look and comment on changes you want me to remove om preparation
for future inference changes. This CL looks like it has a particularly large #
of cases that might be fixed by inference.
Once fixes you want me to remove are gone I'll send it off to owners for review.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b