Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1903)

Issue 19890043: Update hacking.rst to mention reviews.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by bac
Modified:
11 years ago
Reviewers:
mp+193298, benji
Visibility:
Public.

Description

Update hacking.rst to mention reviews. Both Launchpad-only and lbox reviews are detailed. https://code.launchpad.net/~bac/charmworld/update-hacking/+merge/193298 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3

Patch Set 2 : Update hacking.rst to mention reviews. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -3 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M docs/hacking.rst View 1 4 chunks +44 lines, -3 lines 0 comments Download

Messages

Total messages: 5
bac
Please take a look.
11 years ago (2013-10-30 18:03:04 UTC) #1
benji
LGTM with a nit. https://codereview.appspot.com/19890043/diff/1/docs/hacking.rst File docs/hacking.rst (right): https://codereview.appspot.com/19890043/diff/1/docs/hacking.rst#newcode42 docs/hacking.rst:42: ======================== +1 https://codereview.appspot.com/19890043/diff/1/docs/hacking.rst#newcode107 docs/hacking.rst:107: room. ...
11 years ago (2013-10-30 18:16:58 UTC) #2
bac
Please take a look.
11 years ago (2013-10-30 18:46:27 UTC) #3
bac
thanks for the review
11 years ago (2013-10-30 18:57:10 UTC) #4
benji
11 years ago (2013-10-30 19:06:51 UTC) #5
This looks even more LGTM that it did before.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b