Issue 19880043: Add a script to copy the ANGLE DLLs to target folders as part of the new gyp build process.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 19880043: Add a script to copy the ANGLE DLLs to target folders as part of the new gyp build process. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by Jamie Madill

Modified:
10 years, 5 months ago

Reviewers:
Geoff Lang, Shannon Woods

CC:
angleproject-review_googlegroups.com

Base URL:
https://code.google.com/p/angleproject/@es3proto

Visibility:
Public.

More Reviews

Description

Add a script to copy the ANGLE DLLs to target folders as part of the new gyp build process. BUG= ANGLEBUG=503

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -0 lines)			Patch
	M	.gitignore	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	src/angle.gypi	View		2 chunks	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Shannon Woods

Does this actually specifically copy the DLLs, or just invoke a target script that can ...

10 years, 5 months ago (2013-11-08 17:16:12 UTC) #3

Jamie Madill

On 2013/11/08 17:16:12, Shannon Woods wrote: > Does this actually specifically copy the DLLs, or ...

10 years, 5 months ago (2013-11-08 18:13:10 UTC) #4

Shannon Woods

10 years, 5 months ago (2013-11-08 18:27:58 UTC) #5

On 2013/11/08 18:13:10, Jamie Madill wrote:
> On 2013/11/08 17:16:12, Shannon Woods wrote:
> > Does this actually specifically copy the DLLs, or just invoke a target
script
> > that can contain whatever is desired?
> 
> It invokes a script! The title of the patch could be misleading.

That's cool with me! LGTM. Please make sure the commit message is updated before
landing.

Expand All Messages | Collapse All Messages