Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2250)

Issue 197740043: Use charm store API to retrieve GUI revision.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 3 months ago by frankban
Modified:
9 years, 3 months ago
Reviewers:
martin.hilton, mp+246199, rog
Visibility:
Public.

Description

Use charm store API to retrieve GUI revision. This branch includes the following small fixes in preparation for the 1.6 release: - bump version up to 1.6.0; - use the charm store API to retrieve the URL of the last revision of the juju-gui charm; - add initial support for vivid: the new series can now be selected as default bootstrap node series when creating/editing environments. Tests: `make check`. QA: - just run `.venv/bin/python juju-quickstart` as usual, locally and on a ec2 environment (it would be nice if both precise and trusty are used as default series in this QA); check that vivid can be added as a default-series in the environment edit view; check that the last Juju GUI revision is correctly retrieved. https://code.launchpad.net/~frankban/juju-quickstart/initial-vivid-support/+merge/246199 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Use charm store API to retrieve GUI revision. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -28 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M quickstart/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M quickstart/app.py View 2 chunks +3 lines, -3 lines 0 comments Download
M quickstart/netutils.py View 1 chunk +3 lines, -3 lines 0 comments Download
M quickstart/settings.py View 2 chunks +9 lines, -7 lines 0 comments Download
M quickstart/tests/test_app.py View 6 chunks +9 lines, -9 lines 0 comments Download
M quickstart/tests/test_netutils.py View 2 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 6
frankban
Please take a look.
9 years, 3 months ago (2015-01-12 17:54:33 UTC) #1
martin.hilton
LGTM, No QA (yet)
9 years, 3 months ago (2015-01-12 18:02:13 UTC) #2
martin.hilton
On 2015/01/12 18:02:13, martin.hilton wrote: > LGTM, No QA (yet) QA OK
9 years, 3 months ago (2015-01-12 19:46:50 UTC) #3
rog
On 2015/01/12 19:46:50, martin.hilton wrote: > On 2015/01/12 18:02:13, martin.hilton wrote: > > LGTM, No ...
9 years, 3 months ago (2015-01-13 09:44:25 UTC) #4
frankban
*** Submitted: Use charm store API to retrieve GUI revision. This branch includes the following ...
9 years, 3 months ago (2015-01-13 09:48:19 UTC) #5
frankban
9 years, 3 months ago (2015-01-13 09:48:55 UTC) #6
Thanks for the reviews!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b