Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(961)

Issue 197690043: Various fixes/improvements in connection with Smob allocation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by dak
Modified:
4 years, 5 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Various fixes/improvements in connection with Smob allocation These are mostly work towards keeping Guilev2 from crashing all the time. Consists of commits: smobs.tcc: robustify {mark,print}_trampoline in connection with free_smob Guilev2 has little qualms calling mark/print even after freeing a smob. So we clean out the pointer to smob data when freeing/unregistering it, and let the mark/print trampolines detect this condition and punt. Remove Music_function::mark_smob with ASSERT_LIVE_IS_ALLOWED GUILEv2's garbage collection is too asynchronous to make this work. Fix mark_smob definition of (unused) class Smob3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M lily/include/music-function.hh View 1 chunk +0 lines, -1 line 0 comments Download
M lily/include/small-smobs.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/smobs.tcc View 2 chunks +9 lines, -2 lines 0 comments Download
M lily/music-function.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b