Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(31)

Issue 197290043: Directional and omni-directional THz propagation models and tests

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 5 months ago by moshir2
Modified:
4 years, 2 months ago
Reviewers:
Tom Henderson
CC:
ns-3-reviews_googlegroups.com, ns-3-reviews_google.com
Visibility:
Public.

Description

Directional and omni-directional THz propagation models and tests

Patch Set 1 #

Patch Set 2 : Add an example for thz-propagation-loss-model #

Patch Set 3 : add an example file for thz-propation-loss-model that compares omni-directional thz propagtaion mod… #

Patch Set 4 : Adding an example for thz propagation model #

Patch Set 5 : Add directional and omni-directional THz propagation models with test and example files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6335 lines, -0 lines) Patch
A src/propagation/examples/thz-vs-friis-loss-example.cc View 1 2 3 1 chunk +102 lines, -0 lines 0 comments Download
M src/propagation/examples/wscript View 1 1 chunk +5 lines, -0 lines 0 comments Download
A src/propagation/model/absorptionTable.txt View 2 3 4 1 chunk +5121 lines, -0 lines 0 comments Download
A src/propagation/model/thz-propagation-loss-model.h View 1 2 3 4 1 chunk +327 lines, -0 lines 0 comments Download
A src/propagation/model/thz-propagation-loss-model.cc View 2 3 4 1 chunk +556 lines, -0 lines 0 comments Download
A src/propagation/test/thz-propagation-loss-model-test-suite.cc View 2 3 4 1 chunk +221 lines, -0 lines 0 comments Download
M src/propagation/wscript View 1 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Tom Henderson
I had a quick review and couldn't find any statements to comment on; nicely done! ...
4 years, 3 months ago (2015-04-14 04:58:32 UTC) #1
moshir2
4 years, 2 months ago (2015-04-20 01:05:28 UTC) #2
On 2015/04/14 04:58:32, Tom Henderson wrote:
> I had a quick review and couldn't find any statements to comment on; nicely
> done!
> 
> Suggest to provide a more complete reference to the academic work behind this
> (e.g. is the Globecom paper the best/only reference?)
> 
> My only other suggestion might be to provide an example that shows the domain
of
> applicability of this model; what kind of device is attached to this channel? 
> Or perhaps an example that plots using the GnuplotHelper the loss as a
function
> of distance (perhaps comparing it to other models such as Friis), just so
people
> can get their bearings on applying this model.

Dear Tom,

Thanks a lot for your review.

We added one more reference for THz propagation model. 
Also, we wrote an example file that compares omni-directional THz propagation
model with Friis propagation model and plots the loss as a function of distance.

Thanks again and best regards,
Farnoosh
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b