Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(323)

Issue 1971043: Modified samples to test whether ANGLE can recover from a lost context....

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 3 months ago by apatrick1
Modified:
3 weeks, 4 days ago
Reviewers:
Alok Priyadarshi
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Modified samples to test whether ANGLE can recover from a lost context. When eglGetError returns EGL_CONTEXT_LOST, the samples now attempt to create a new EGL context and reinitialize. I haven't been able to test whether the reinitialization path works yet because ANGLE fails to make the new context current, I think because it doesn't reset the D3D device and its still in a lost state. I want to check this in though because it is a useful way of testing context lost recovery. I also made the samples return an error code when they fail.

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -191 lines) Patch
M samples/gles2_book/Common/Win32/esUtil_win32.c View 1 3 chunks +26 lines, -2 lines 0 comments Download
M samples/gles2_book/Common/esUtil.h View 4 chunks +25 lines, -2 lines 0 comments Download
M samples/gles2_book/Common/esUtil.c View 7 chunks +88 lines, -36 lines 0 comments Download
M samples/gles2_book/Hello_Triangle/Hello_Triangle.c View 3 chunks +3 lines, -5 lines 0 comments Download
M samples/gles2_book/MipMap2D/MipMap2D.c View 3 chunks +3 lines, -21 lines 0 comments Download
M samples/gles2_book/MultiTexture/MultiTexture.c View 3 chunks +3 lines, -22 lines 0 comments Download
M samples/gles2_book/ParticleSystem/ParticleSystem.c View 3 chunks +3 lines, -21 lines 0 comments Download
M samples/gles2_book/Simple_Texture2D/Simple_Texture2D.c View 3 chunks +4 lines, -22 lines 0 comments Download
M samples/gles2_book/Simple_TextureCubemap/Simple_TextureCubemap.c View 4 chunks +5 lines, -14 lines 0 comments Download
M samples/gles2_book/Simple_VertexShader/Simple_VertexShader.c View 4 chunks +3 lines, -5 lines 0 comments Download
M samples/gles2_book/Stencil_Test/Stencil_Test.c View 3 chunks +4 lines, -19 lines 0 comments Download
M samples/gles2_book/TextureWrap/TextureWrap.c View 3 chunks +4 lines, -22 lines 0 comments Download

Messages

Total messages: 3
apatrick1
8 years, 3 months ago (2010-08-13 19:20:36 UTC) #1
Alok Priyadarshi
Why have you removed all ShutDown functions. Shouldn't you be registering those instead? http://codereview.appspot.com/1971043/diff/1/2 File ...
8 years, 3 months ago (2010-08-16 19:24:36 UTC) #2
apatrick1
8 years, 3 months ago (2010-08-16 19:45:39 UTC) #3
http://codereview.appspot.com/1971043/diff/1/2
File samples/gles2_book/Common/Win32/esUtil_win32.c (right):

http://codereview.appspot.com/1971043/diff/1/2#newcode67
samples/gles2_book/Common/Win32/esUtil_win32.c:67: {
On 2010/08/16 19:24:37, alokp wrote:
> nit: brackets not necessary.

Done.

http://codereview.appspot.com/1971043/diff/1/6
File samples/gles2_book/MipMap2D/MipMap2D.c (left):

http://codereview.appspot.com/1971043/diff/1/6#oldcode316
samples/gles2_book/MipMap2D/MipMap2D.c:316: void ShutDown ( ESContext *esContext
)
On 2010/08/16 19:24:37, alokp wrote:
> this is not necessary anymore?

Yeah it's not needed because the samples now call eglDestroyContext, which
destroys any GL resources implicitly. I only left Shutdown functions for samples
that destroy non-GL resources.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b