code review 19710043: leveldb: implement deleteObsoleteFiles.

leveldb: implement deleteObsoleteFiles.

Also implement tableCache eviction, parseDBFilename, and delete the
logFileNum function.

[nigeltao, 2013-10-30 07:12:19]

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/leveldb-go

[bradfitz, 2013-10-30 07:35:38]

LGTM

Comments, but nothing important.

https://codereview.appspot.com/19710043/diff/40001/leveldb/filenames.go
File leveldb/filenames.go (right):

https://codereview.appspot.com/19710043/diff/40001/leveldb/filenames.go#newco...
leveldb/filenames.go:44: func parseDBFilename(filename string) (fileType int,
fileNum uint64, ok bool) {
if the variable has "type" in its name and is an integer, that might be a sign
you should use a Go type.

https://codereview.appspot.com/19710043/diff/40001/leveldb/filenames.go#newco...
leveldb/filenames.go:52: u, err :=
strconv.ParseUint(filename[len("MANIFEST-"):], 10, 64)
strings.TrimPrefix(filename, "MANIFEST-")

it does another HasPrefix call, but reads nicely.  *shrug*  either way.

https://codereview.appspot.com/19710043/diff/40001/leveldb/table_cache_test.go
File leveldb/table_cache_test.go (right):

https://codereview.appspot.com/19710043/diff/40001/leveldb/table_cache_test.g...
leveldb/table_cache_test.go:263: // The magic 1.25 number isn't derived from
formal modelling. It's just a guess. For
damn British spelling. :P

[nigeltao, 2013-10-31 00:29:05]

*** Submitted as
https://code.google.com/p/leveldb-go/source/detail?r=d752f26707c7 ***

leveldb: implement deleteObsoleteFiles.

Also implement tableCache eviction, parseDBFilename, and delete the
logFileNum function.

R=bradfitz
CC=golang-dev
https://codereview.appspot.com/19710043