Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(331)

Issue 1961041: Change PluginCompilerMain to combine output when one output file specified (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 10 months ago by MikeSamuel
Modified:
15 years, 10 months ago
Reviewers:
Jasvir
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

If the user specifies only HTML output by using the -h flag without a corresponding -j flag, then combine the JS into the HTML. Or vice versa, if the -j flag is specified, but not -h then use the html emitter to dump the HTML. Submitted @4247

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change PluginCompilerMain to combine output when one output file specified #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -35 lines) Patch
M src/com/google/caja/plugin/Config.java View 1 4 chunks +10 lines, -21 lines 0 comments Download
M src/com/google/caja/plugin/PluginCompilerMain.java View 1 6 chunks +42 lines, -14 lines 0 comments Download

Messages

Total messages: 3
MikeSamuel
15 years, 10 months ago (2010-08-10 16:28:35 UTC) #1
Jasvir
LGTM http://codereview.appspot.com/1961041/diff/1/3 File src/com/google/caja/plugin/Config.java (right): http://codereview.appspot.com/1961041/diff/1/3#newcode301 src/com/google/caja/plugin/Config.java:301: outputJsFile = cl.getOptionValue(OUTPUT_JS.getOpt()) == null Its probably worth ...
15 years, 10 months ago (2010-08-16 19:45:23 UTC) #2
MikeSamuel
15 years, 10 months ago (2010-08-16 23:56:22 UTC) #3
http://codereview.appspot.com/1961041/diff/1/3
File src/com/google/caja/plugin/Config.java (right):

http://codereview.appspot.com/1961041/diff/1/3#newcode301
src/com/google/caja/plugin/Config.java:301: outputJsFile =
cl.getOptionValue(OUTPUT_JS.getOpt()) == null
On 2010/08/16 19:45:23, jasvir wrote:
> Its probably worth noting in the documentation that the html file that results
> is not independently loadable without the extra script line that loads the
caja
> runtime and sets up the environment.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b