Issue 1960047: Add code review upload script

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1960047: Add code review upload script

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by techtonik

Modified:
13 years, 8 months ago

Reviewers:
Steven Knight, gary.oberbrunner

CC:
dev_scons.tigris.org

Base URL:
http://scons.tigris.org/svn/scons/trunk/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Add default VCS and CC options #

Patch Set 3 : Send notification email by default #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1781 lines, -0 lines)			Patch
	M	README	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	A	review.py	View	1 2	1 chunk	+1777 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Steven Knight

I'd rather see this in bin/review.py. There's enough clutter in the top-level directory as it ...

13 years, 8 months ago (2010-08-23 17:31:34 UTC) #2

gary.oberbrunner

On 2010/08/23 17:31:34, Steven Knight wrote: > I'd rather see this in bin/review.py. There's enough ...

13 years, 8 months ago (2010-08-23 17:41:08 UTC) #3

Bad Dog Consulting

Gary, On Mon, Aug 23, 2010 at 10:41 AM, <gary.oberbrunner@gmail.com> wrote: ... > Also, just ...

13 years, 8 months ago (2010-08-23 20:06:38 UTC) #4

gary.oberbrunner

13 years, 8 months ago (2010-08-23 21:17:02 UTC) #5

On 8/23/2010 4:06 PM, William Deegan wrote:
> Gary,
> 
> On Mon, Aug 23, 2010 at 10:41 AM,  <gary.oberbrunner@gmail.com> wrote:
> ...
>> Also, just a note: anyone who doesn't use their google account to post
>> to the scons dev list will need to add their google account as an
>> approved poster, since reviews get CCed to the dev list and appear to
>> come from whoever you're logged into appspot as.
> 
> I don't.  How do I do this?

I just had to do myself.  :-)

Go to scons.tigris.org, log in, click My pages (top left), My profile
(just below that).  Then add a Secondary email address (or more).  Solve
the annoying captcha and "submit changes."

-- 
Gary Oberbrunner

Expand All Messages | Collapse All Messages