Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(886)

Issue 1960047: Add code review upload script

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 8 months ago by techtonik
Modified:
3 years, 8 months ago
CC:
dev_scons.tigris.org
Base URL:
http://scons.tigris.org/svn/scons/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Add default VCS and CC options #

Patch Set 3 : Send notification email by default #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1781 lines, -0 lines) Patch
M README View 1 chunk +4 lines, -0 lines 0 comments Download
A review.py View 1 2 1 chunk +1777 lines, -0 lines 0 comments Download

Messages

Total messages: 5
techtonik
3 years, 8 months ago #1
Steven Knight
I'd rather see this in bin/review.py. There's enough clutter in the top-level directory as it ...
3 years, 8 months ago #2
gary.oberbrunner
On 2010/08/23 17:31:34, Steven Knight wrote: > I'd rather see this in bin/review.py. There's enough ...
3 years, 8 months ago #3
Bad Dog Consulting
Gary, On Mon, Aug 23, 2010 at 10:41 AM, <gary.oberbrunner@gmail.com> wrote: ... > Also, just ...
3 years, 8 months ago #4
gary.oberbrunner
3 years, 8 months ago #5
On 8/23/2010 4:06 PM, William Deegan wrote:
> Gary,
> 
> On Mon, Aug 23, 2010 at 10:41 AM,  <gary.oberbrunner@gmail.com> wrote:
> ...
>> Also, just a note: anyone who doesn't use their google account to post
>> to the scons dev list will need to add their google account as an
>> approved poster, since reviews get CCed to the dev list and appear to
>> come from whoever you're logged into appspot as.
> 
> I don't.  How do I do this?

I just had to do myself.  :-)

Go to scons.tigris.org, log in, click My pages (top left), My profile
(just below that).  Then add a Secondary email address (or more).  Solve
the annoying captcha and "submit changes."

-- 
Gary Oberbrunner
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5