Update to Tornado 3.2.2.

Update to Tornado 3.2.2.

This is done as an attempt to fix the
Tornado race condition described in [1]

Also use the newest version of the
futures package.

Add the missing firefox dependency to the 
sysdeps make target.

Simplify the GUI server WebSocket client now that
Tornado supports close() out of the box.

Update the utils.clone_request function so that
the ProxyHandler does not fail if a GET request
is performed with an empty string body.

Other tests fixes.

Tests: `make lint unittest`

QA:
- bootstrap an environment;
- run `make deploy` and wait for the GUI to be ready;
- use the GUI as usual to deploy charms and bundles:
  ensure everything works as usual, with events correctly
  reported by the GUI and no disconnections from core
  happen;
- use `juju ssh juju-gui/0 sudo tailf /var/log/upstart/guiserver.log`
  to check no errors are reported by the GUI server while
  working with the GUI;
- ensure the juju-gui icon is correctly displayed in the service view
  (meaning local charm icons are still properly retrieved from core);
- destroy the environment.

[1] https://bugs.launchpad.net/juju-gui/+bug/1402061

https://code.launchpad.net/~frankban/charms/trusty/juju-gui/test-fixes/+merge/245575

(do not edit description out of merge proposal)

[frankban, 2015-01-05 14:17:48]

Please take a look.

[rharding, 2015-01-05 15:32:16]

code is LGTM with one comment. Working on setting up a QA env.

https://codereview.appspot.com/195720043/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/195720043/diff/1/Makefile#newcode19
Makefile:19: SYSDEPS = build-essential bzr charm-tools firefox libapt-pkg-dev \
this also needs to get to the automated testing dep list. They have a yaml file
they use to pick up deps and don't run 'make sysdeps'

https://codereview.appspot.com/195720043/diff/1/server/guiserver/tests/test_u...
File server/guiserver/tests/test_utils.py (right):

https://codereview.appspot.com/195720043/diff/1/server/guiserver/tests/test_u...
server/guiserver/tests/test_utils.py:62: self.stop()
maybe a comment on how this is required now?

[rharding, 2015-01-05 15:57:13]

QA ok LGTM

[rharding, 2015-01-05 15:58:05]

So the only thing to check is that tests/tests.yaml matches what make sysdeps
thinks/wants so that the automated tests match up to our own tests.

[frankban, 2015-01-05 16:23:12]

On 2015/01/05 15:58:05, rharding wrote:
> So the only thing to check is that tests/tests.yaml matches what make sysdeps
> thinks/wants so that the automated tests match up to our own tests.

Those already match, thanks for the suggestion. I added a Makefile note to keep
them in sync.

[frankban, 2015-01-05 16:27:06]

Please take a look.

[martin.hilton, 2015-01-05 17:41:36]

On 2015/01/05 16:27:06, frankban wrote:
> Please take a look.

LGTM

[frankban, 2015-01-05 18:12:41]

*** Submitted:

Update to Tornado 3.2.2.

This is done as an attempt to fix the
Tornado race condition described in [1]

Also use the newest version of the
futures package.

Add the missing firefox dependency to the 
sysdeps make target.

Simplify the GUI server WebSocket client now that
Tornado supports close() out of the box.

Update the utils.clone_request function so that
the ProxyHandler does not fail if a GET request
is performed with an empty string body.

Other tests fixes.

Tests: `make lint unittest`

QA:
- bootstrap an environment;
- run `make deploy` and wait for the GUI to be ready;
- use the GUI as usual to deploy charms and bundles:
  ensure everything works as usual, with events correctly
  reported by the GUI and no disconnections from core
  happen;
- use `juju ssh juju-gui/0 sudo tailf /var/log/upstart/guiserver.log`
  to check no errors are reported by the GUI server while
  working with the GUI;
- ensure the juju-gui icon is correctly displayed in the service view
  (meaning local charm icons are still properly retrieved from core);
- destroy the environment.

[1] https://bugs.launchpad.net/juju-gui/+bug/1402061

R=rharding, martin.hilton
CC=
https://codereview.appspot.com/195720043

[frankban, 2015-01-05 18:15:17]

Thanks for the reviews!