Issue 19570043: Adds confirmation to bundle deploy

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 19570043: Adds confirmation to bundle deploy

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by jeff.pihach

Modified:
10 years, 6 months ago

Reviewers:
gary.poster, mp+193158

Visibility:
Public.

Description

Adds confirmation to bundle deploy When clicking the 'add to canvas' button in the bundle details page it will now show a notification above the button and require an additional click on the button which now reads, 'Yes, I'm sure'. https://code.launchpad.net/~hatch/juju-gui/bundle-confirm/+merge/193158 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Adds confirmation to bundle deploy #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+81 lines, -19 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/index.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	app/subapps/browser/views/bundle.js	View	2 chunks	+21 lines, -1 line	0 comments	Download
M	app/templates/bundle.handlebars	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	app/views/notifications.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/views/browser/charm-full.less	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/views/browser/main.less	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	lib/views/stylesheet.less	View	3 chunks	+13 lines, -1 line	0 comments	Download
M	test/test_bundle_details_view.js	View	1 chunk	+25 lines, -8 lines	0 comments	Download
M	test/test_charm_running.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/test_notifications.js	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	test/test_notifier_widget.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jeff.pihach

10 years, 6 months ago (2013-10-30 04:07:23 UTC) #4

*** Submitted:

Adds confirmation to bundle deploy

When clicking the 'add to canvas' button in the bundle
details page it will now show a notification above the
button and require an additional click on the button
which now reads, 'Yes, I'm sure'.

R=gary.poster
CC=
https://codereview.appspot.com/19570043

Expand All Messages | Collapse All Messages