Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(722)

Issue 195690043: Make ftests fail if Juju env is not ready.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by frankban
Modified:
10 years, 1 month ago
Reviewers:
kadams54, mp+248755, jeff.pihach
Visibility:
Public.

Description

Make ftests fail if Juju env is not ready. The functional tests are no longer silently skipped if the default Juju environment cannot be found. Also fail if the environment is running, as this would cause it to be destroyed at the end of the suite. QA: - bootstrap your default environment; - run `make ftest`/`make fcheck` and ensure the functional tests fail (environment already bootstrapped); - destroy your environment; - run `make fcheck` again and ensure all the suites complete successfully. https://code.launchpad.net/~frankban/juju-quickstart/ftest-fixes/+merge/248755 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Make ftests fail if Juju env is not ready. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -11 lines) Patch
M HACKING.rst View 2 chunks +2 lines, -1 line 0 comments Download
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M quickstart/tests/functional/test_functional.py View 3 chunks +44 lines, -10 lines 0 comments Download

Messages

Total messages: 5
frankban
Please take a look.
10 years, 1 month ago (2015-02-05 13:37:38 UTC) #1
jeff.pihach
LGTM Thanks for this follow-up!
10 years, 1 month ago (2015-02-05 15:34:28 UTC) #2
kadams54
LGTM as well.
10 years, 1 month ago (2015-02-05 16:06:18 UTC) #3
frankban
*** Submitted: Make ftests fail if Juju env is not ready. The functional tests are ...
10 years, 1 month ago (2015-02-05 16:35:07 UTC) #4
frankban
10 years, 1 month ago (2015-02-05 16:35:39 UTC) #5
Thanks for the reviews!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b