Album/MediaItem Implementation

Patch from Eric Woods for SHINDIG-1410

[henry.saputra, 2010-08-17 02:15:50]

Some comments. 

Correct me if I am wrong but AFAIK we need to add Operation.name to the
@Operation annon to make sure the right RPC handler, eg: albums.create, is
created and registered in the handler registry.

- Henry

http://codereview.appspot.com/1955045/diff/1/4
File
java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/AlbumHandler.java
(right):

http://codereview.appspot.com/1955045/diff/1/4#newcode64
java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/AlbumHandler.java:64:
@Operation(httpMethods = "POST", bodyParam = "album")
Need to add name="create" to create the right RPC handler.

http://codereview.appspot.com/1955045/diff/1/4#newcode131
java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/AlbumHandler.java:131:
@Operation(httpMethods = "PUT", bodyParam = "album")
Need to add name="update" to create the right RPC handler.

http://codereview.appspot.com/1955045/diff/1/4#newcode156
java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/AlbumHandler.java:156:
@Operation(httpMethods = "DELETE")
Need to add name="delete" to create the right RPC handler.

http://codereview.appspot.com/1955045/diff/1/4#newcode175
java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/AlbumHandler.java:175:
public List<Object> supportedFields(RequestItem request) {
According to OpenSocial spec 0.9:
http://www.opensocial.org/Technical-Resources/opensocial-spec-v09/RPC-Protoco...
http://www.opensocial.org/Technical-Resources/opensocial-spec-v09/REST-API.ht...

both Album and MediaItem dont support "supportedFields" api.

http://codereview.appspot.com/1955045/diff/1/5
File
java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/MediaItemHandler.java
(right):

http://codereview.appspot.com/1955045/diff/1/5#newcode118
java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/MediaItemHandler.java:118:
@Operation(httpMethods = "DELETE")
Need to add name="delete" to create the right RPC handler.

http://codereview.appspot.com/1955045/diff/1/5#newcode144
java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/MediaItemHandler.java:144:
@Operation(httpMethods = "POST", bodyParam = "mediaItem")
Need to add name="carete" to create the right RPC handler.

http://codereview.appspot.com/1955045/diff/1/5#newcode169
java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/MediaItemHandler.java:169:
@Operation(httpMethods = "PUT", bodyParam = "mediaItem")
Need to add name="update" to create the right RPC handler.

http://codereview.appspot.com/1955045/diff/1/5#newcode191
java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/MediaItemHandler.java:191:
public List<Object> supportedFields(RequestItem request) {
According to OpenSocial v0.9 MediaItem REST and RPC dont support supportedField
operation.

[henry.saputra, 2010-08-17 02:36:58]

Hi guys,

Please ignore the review to add name to the Operation annotation =(

I missed the code
String opName = m.getName(); 
in the DefaultHandlerRegistry.createRpcHandler() function which takes method
name as opName default.

Sorry.

I hate Mondays =P

- Henry

http://codereview.appspot.com/1955045/diff/1/4
File
java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/AlbumHandler.java
(right):

http://codereview.appspot.com/1955045/diff/1/4#newcode64
java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/AlbumHandler.java:64:
@Operation(httpMethods = "POST", bodyParam = "album")
Arrgh ignore this, miss the code
String opName = m.getName(); which takes method name as opName default =(

http://codereview.appspot.com/1955045/diff/1/4#newcode131
java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/AlbumHandler.java:131:
@Operation(httpMethods = "PUT", bodyParam = "album")
Arrgh ignore this, miss the code
String opName = m.getName(); which takes method name as opName default =(

http://codereview.appspot.com/1955045/diff/1/4#newcode156
java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/AlbumHandler.java:156:
@Operation(httpMethods = "DELETE")
Arrgh ignore this, miss the code
String opName = m.getName(); which takes method name as opName default =(

http://codereview.appspot.com/1955045/diff/1/5
File
java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/MediaItemHandler.java
(right):

http://codereview.appspot.com/1955045/diff/1/5#newcode118
java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/MediaItemHandler.java:118:
@Operation(httpMethods = "DELETE")
Arrgh ignore this, miss the code
String opName = m.getName(); which takes method name as opName default =(

http://codereview.appspot.com/1955045/diff/1/5#newcode144
java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/MediaItemHandler.java:144:
@Operation(httpMethods = "POST", bodyParam = "mediaItem")
Arrgh ignore this, miss the code
String opName = m.getName(); which takes method name as opName default =(

http://codereview.appspot.com/1955045/diff/1/5#newcode169
java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/MediaItemHandler.java:169:
@Operation(httpMethods = "PUT", bodyParam = "mediaItem")
Arrgh ignore this, miss the code
String opName = m.getName(); which takes method name as opName default =(