Issue 1955041: code review 1955041: 16 bits grayscale in png

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1955041: code review 1955041: 16 bits grayscale in png

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by mpl

Modified:
13 years, 8 months ago

Reviewers:
nigeltao

CC:
golang-dev

Visibility:
Public.

Description

16 bits grayscale in png

Patch Set 1 #

Patch Set 2 : code review 1955041: 16 bits grayscale in png #

Total comments: 1

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -20 lines)			Patch
M	src/pkg/image/png/reader.go	View	4 chunks	+30 lines, -8 lines	1 comment	Download
M	src/pkg/image/png/reader_test.go	View	3 chunks	+16 lines, -6 lines	0 comments	Download
M	src/pkg/image/png/writer.go	View	4 chunks	+26 lines, -6 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

mpl

Hello nigeltao_golang (cc: golang-dev@googlegroups.com), I'd like you to review this change.

13 years, 8 months ago (2010-08-10 10:28:23 UTC) #1

mpl

13 years, 8 months ago (2010-08-10 10:38:13 UTC) #2

http://codereview.appspot.com/1955041/diff/2001/3001
File src/pkg/image/png/reader.go (right):

http://codereview.appspot.com/1955041/diff/2001/3001#newcode126
src/pkg/image/png/reader.go:126: }
For this one I think it would be more generic to have the outer switch over the
bitdepth. I kept it inside instead to save us from one switch call in the non
grayscale cases, since we don't support other bitdepths for those for now.

Expand All Messages | Collapse All Messages