Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(324)

Issue 1951042: Review: back out LLVM pass changes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by larrygritz
Modified:
13 years, 3 months ago
Reviewers:
aconty, ckulla
CC:
dev-osl_imageworks.com, osl-dev_googlegroups.com
Base URL:
http://openshadinglanguage.googlecode.com/svn/trunk/
Visibility:
Public.

Description

I've spent several days tracking down crashes in our LLVM-generated code, with little satisfaction. I still don't know if this reveals bugs in LLVM or that we have subtly misused it, but in any case I think we need to back out the changes from about a week ago where I radically altered which optimization passes we were scheduling. This patch takes us back to a place where we run without crashing, although MUCH slower than we'd like to be. But now that we are correct, I'll work again on optimization, this time more slowly and carefully, to ensure that we identify exactly what changes bring us to dragon territory.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -13 lines) Patch
src/liboslexec/CMakeLists.txt View 1 chunk +1 line, -1 line 0 comments Download
src/liboslexec/llvm_instance.cpp View 7 chunks +70 lines, -12 lines 0 comments Download

Messages

Total messages: 4
larrygritz
13 years, 3 months ago (2010-08-11 16:34:40 UTC) #1
aconty
So this just reverts your previous commit? Go ahead and we'll take it from there.
13 years, 3 months ago (2010-08-11 18:40:16 UTC) #2
ckulla
LGTM
13 years, 3 months ago (2010-08-11 18:49:58 UTC) #3
lg_imageworks.com
13 years, 3 months ago (2010-08-11 19:42:50 UTC) #4
Effectively, yes.  But it's slightly more complex than a simple revert, as it
keeps the non-working newer version present but #ifdef-ed out, so I can refer it
as we move forward to reconstruct the most highly optimized set that continues
to work properly.


On Aug 11, 2010, at 11:40 AM, <aconty@gmail.com> <aconty@gmail.com> wrote:

> So this just reverts your previous commit? Go ahead and we'll take it
> from there.
> 
> http://codereview.appspot.com/1951042/show
> 
> -- 
> You received this message because you are subscribed to the Google Groups "OSL
Developers" group.
> To post to this group, send email to osl-dev@googlegroups.com.
> To unsubscribe from this group, send email to
osl-dev+unsubscribe@googlegroups.com.
> For more options, visit this group at
http://groups.google.com/group/osl-dev?hl=en.
> 
> 

--
Larry Gritz
lg@imageworks.com




Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b