Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1169)

Issue 195078: Two improvements to perf.py

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 2 months ago by Collin Winter
Modified:
3 years, 2 months ago
CC:
unladen-swallow_googlegroups.com
Base URL:
http://unladen-swallow.googlecode.com/svn/tests/
Visibility:
Public.

Description

1. Log how many memory samples were collected. I want to improve the sampling
rate going forward.
2. Give the charts dynamically-sized margins. This improves the performance
timeline for float, for example: (old)  http://tinyurl.com/ybxvmck -> (new)
http://tinyurl.com/ykyaeb8.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M perf.py View 4 chunks +14 lines, -8 lines 2 comments Download

Messages

Total messages: 3
Collin Winter
PTAL
4 years, 2 months ago #1
Jeffrey Yasskin
Otherwise, LGTM. http://codereview.appspot.com/195078/diff/1/2 File perf.py (right): http://codereview.appspot.com/195078/diff/1/2#newcode515 perf.py:515: # Add a 10% margin, top and ...
4 years, 2 months ago #2
5591boy
3 years, 2 months ago #3
On 2010/01/27 23:05:16, Collin Winter wrote:
> PTAL
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5