Issue 195073: Handle relative redirection in BasicHttpFetcher

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 195073: Handle relative redirection in BasicHttpFetcher

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by zhoresh

Modified:
14 years, 3 months ago

Reviewers:
Paul Lindner, johnfargo, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Description

Redirection requests (302), can specify location relative to source location. (for example try to get http://my.yahoo.com/) This change fix BasicHttpFetcher to follow such redirection correctly.

Patch Set 1 #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -1 line)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/http/BasicHttpFetcher.java	View		2 chunks	+4 lines, -0 lines	0 comments	Download
		java/gadgets/src/test/java/org/apache/shindig/gadgets/http/AbstractHttpFetcherTest.java	View		1 chunk	+14 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Paul Lindner

Thanks for the test case. This works with the httpclient 4.0 code I just proposed.

14 years, 3 months ago (2010-01-29 03:36:12 UTC) #2

Code committed.

Expand All Messages | Collapse All Messages