Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(147)

Issue 1948041: Issue 1242 : rename HTMLElement.{g,s}etStyle method to avoid conflicts (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 10 months ago by MikeSamuel
Modified:
15 years, 10 months ago
Reviewers:
Jasvir
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

http://code.google.com/p/google-caja/issues/detail?id=1242 This change expands the use of defAttributeAlias and generalizes it to defProperty and changes the names of the getter/setter properties added to wrapper prototypes to have ___ at the end. Submitted @4248

Patch Set 1 #

Patch Set 2 : Issue 1242 : rename HTMLElement.{g,s}etStyle method to avoid conflicts #

Patch Set 3 : Issue 1242 : rename HTMLElement.{g,s}etStyle method to avoid conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+348 lines, -537 lines) Patch
M src/com/google/caja/plugin/domita.js View 1 2 54 chunks +339 lines, -533 lines 0 comments Download
M tests/com/google/caja/plugin/domita_test_untrusted.html View 1 2 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 3
MikeSamuel
15 years, 10 months ago (2010-08-10 03:45:55 UTC) #1
MikeSamuel
ping
15 years, 10 months ago (2010-08-17 20:35:43 UTC) #2
Jasvir
15 years, 10 months ago (2010-08-17 22:27:37 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b