Issue 194390043: Misc cleanup. Move super calls to end of constructor initialization list matching the Dart style gu…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 194390043: Misc cleanup. Move super calls to end of constructor initialization list matching the Dart style gu…

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 3 months ago by jacobr

Modified:
9 years, 3 months ago

Reviewers:
yjbanov

Base URL:
git@github.com:yjbanov/barista.git@master

Visibility:
Public.

More Reviews

Description

Misc cleanup. Move super calls to end of constructor initialization list matching the Dart style guide. https://www.dartlang.org/articles/style-guide/#do-place-the-super-call-last-in-a-constructor-initialization-list Fix method that accidentally had a different signature in the subclass and base class. BUG=

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -11 lines)			Patch
M	lib/messaging/isolate.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/src/vdom/nodes/element.dart	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	lib/src/vdom/nodes/text.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

jacobr

9 years, 3 months ago (2015-01-23 22:33:01 UTC) #1

Misc cleanup. Move super calls to end of constructor initialization list
matching the Dart style guide.
   
https://www.dartlang.org/articles/style-guide/#do-place-the-super-call-last-i...

Fix method that accidentally had a different signature in the subclass and base
class.

Expand All Messages | Collapse All Messages