Fix SHINDIG-1260

Improper JavaScript inclusion logic leads to out-of-order and duplicate includes / JavaScript errors.

1) feature list sorted.
2) un-used features are removed from forcedJsLibs
3) re-factored Gadget*Renderer.php

TODO:
1) cache management
2) don't expend the js on JsServlet.

[Jacky Wang, 2010-01-26 10:22:37]

patch - don't expend the js on JsServlet.

[Jacky Wang, 2010-02-01 12:40:38]

fix the unit-test.

[Jacky Wang, 2010-02-01 12:42:36]

Fix the unit-test.

[Jacky Wang, 2010-02-01 13:07:30]

Hi All,

This patch is complete now.

Basically, it fixes the issue SHINDIG-1260, which could be found here:
http://issues.apache.org/jira/browse/SHINDIG-1260

In details, this patch does the following things:

1. Change all the name "focedJsLibs" to "forcedJsLibs".

2. Sort the order of features according to their dependencies.

3. If the forced-javascript-lib is not included in the required features, it
won't be included in the generated gadget, and it won't be appear in the
gadget.init, either.

4. JsServlet's behaviors is changed: it won't expand the javascript content
according to the dependency anymore.  This prevent the redundant inclusion of
the js content.

5. The js generating logic is changed:
   Given a dependency graph inl_A <- inl_B <- fjl_C <- fjl_D <- inl_E <- fjl_F
(inl = inline, fjl = forcedJsLib):
   The existing solution produces [fjl: C+D+F], [inline A+B+E] in the
header/body.  However, it breaks the dependency graph.
   In contrast, this new patch groups the features into groups, and each one
belongs to either "inlined" or "forced external".
   Therefore the example yields the following groups: [inl_A, inl_B], [fjl_C,
fjl_D], [inl_E], [fjl_F] and generates the proper code in header/body.

6. Since the dependency graph might generate different topological sorted
orders, heuristic method is used to make the feature group number as less as
possible, thus reduces the outbound request number of javascript content.

I've tested it against many gadgets, and it works quite well.

Hope it helps.

Cheers,
Jacky

On 2010/02/01 12:42:36, Jacky Wang wrote:
> Fix the unit-test.