Show bundle change log.

Show bundle change log.

Other changes:
 * Change date format for charm and bundle change logs to be like 2013-10-31.
 * Lots of drive-by typo fixes.  Sorry for the noise but I cannot help myself.

https://code.launchpad.net/~bac/juju-gui/bundle-change-log/+merge/193134

(do not edit description out of merge proposal)

[bac, 2013-10-29 20:47:11]

Please take a look.

[jeff.pihach, 2013-10-29 21:07:49]

Thanks for this branch!

LGTM with some trivial cleanups below.
QA OK!

https://codereview.appspot.com/19380044/diff/1/app/models/bundle.js
File app/models/bundle.js (right):

https://codereview.appspot.com/19380044/diff/1/app/models/bundle.js#newcode44
app/models/bundle.js:44: 
missing param doc

https://codereview.appspot.com/19380044/diff/1/app/models/bundle.js#newcode46
app/models/bundle.js:46: var loadRecentCommits = function(changes) {
(trivial) this doesn't really load anything - I'd prefer a rename to something
more like extractRecentCommits

(not so trivial) we cannot test this function directly because it's within a
closure - maybe entertain the idea of including it as a prototype method of the
bundle model so that we can do just that.

https://codereview.appspot.com/19380044/diff/1/app/models/bundle.js#newcode204
app/models/bundle.js:204: 'recent_commits': {
quotes aren't necessary
camelCase plz

https://codereview.appspot.com/19380044/diff/1/app/models/charm.js
File app/models/charm.js (right):

https://codereview.appspot.com/19380044/diff/1/app/models/charm.js#newcode77
app/models/charm.js:77: var loadRecentCommits = function(revisions) {
See similar comment from bundle model.

https://codereview.appspot.com/19380044/diff/1/app/subapps/browser/views/bund...
File app/subapps/browser/views/bundle.js (right):

https://codereview.appspot.com/19380044/diff/1/app/subapps/browser/views/bund...
app/subapps/browser/views/bundle.js:160: @private
(trivial) calling this method has no side effects so I would probably just call
this @protected

https://codereview.appspot.com/19380044/diff/1/app/subapps/browser/views/bund...
app/subapps/browser/views/bundle.js:186: templateData.sourceLink =
this._getSourceLink();
at this point we should have the branch_spec property so you could pass it in to
avoid the extra attribute call...of course at that point I would question that
methods purpose at all as all it's doing is concatenating a string once so that
could probably be done inline.

[benji, 2013-10-29 21:13:17]

LGTM

https://codereview.appspot.com/19380044/diff/1/app/subapps/browser/views/bund...
File app/subapps/browser/views/bundle.js (right):

https://codereview.appspot.com/19380044/diff/1/app/subapps/browser/views/bund...
app/subapps/browser/views/bundle.js:161: */
An @return would be nice.

https://codereview.appspot.com/19380044/diff/1/app/subapps/browser/views/char...
File app/subapps/browser/views/charm.js (right):

https://codereview.appspot.com/19380044/diff/1/app/subapps/browser/views/char...
app/subapps/browser/views/charm.js:306: var templateData = charm.getAttrs(),
+1

[bac, 2013-10-30 13:12:23]

*** Submitted:

Show bundle change log.

Other changes:
 * Change date format for charm and bundle change logs to be like 2013-10-31.
 * Lots of drive-by typo fixes.  Sorry for the noise but I cannot help myself.

R=jeff.pihach, benji
CC=
https://codereview.appspot.com/19380044

https://codereview.appspot.com/19380044/diff/1/app/models/bundle.js
File app/models/bundle.js (right):

https://codereview.appspot.com/19380044/diff/1/app/models/bundle.js#newcode44
app/models/bundle.js:44: 
On 2013/10/29 21:07:49, jeff.pihach wrote:
> missing param doc

Done.

https://codereview.appspot.com/19380044/diff/1/app/models/bundle.js#newcode46
app/models/bundle.js:46: var loadRecentCommits = function(changes) {
On 2013/10/29 21:07:49, jeff.pihach wrote:
> (trivial) this doesn't really load anything - I'd prefer a rename to something
> more like extractRecentCommits

Done

> 
> (not so trivial) we cannot test this function directly because it's within a
> closure - maybe entertain the idea of including it as a prototype method of
the
> bundle model so that we can do just that.

Considering

https://codereview.appspot.com/19380044/diff/1/app/models/bundle.js#newcode204
app/models/bundle.js:204: 'recent_commits': {
On 2013/10/29 21:07:49, jeff.pihach wrote:
> quotes aren't necessary
> camelCase plz

Both the quotes and name were copied from charms.js.  Fixed in both places.

https://codereview.appspot.com/19380044/diff/1/app/models/charm.js
File app/models/charm.js (right):

https://codereview.appspot.com/19380044/diff/1/app/models/charm.js#newcode77
app/models/charm.js:77: var loadRecentCommits = function(revisions) {
On 2013/10/29 21:07:49, jeff.pihach wrote:
> See similar comment from bundle model.

Done.

https://codereview.appspot.com/19380044/diff/1/app/subapps/browser/views/bund...
File app/subapps/browser/views/bundle.js (right):

https://codereview.appspot.com/19380044/diff/1/app/subapps/browser/views/bund...
app/subapps/browser/views/bundle.js:160: @private
I don't understand your distinction but it is a moot point as I'm removing the
method.

https://codereview.appspot.com/19380044/diff/1/app/subapps/browser/views/bund...
app/subapps/browser/views/bundle.js:161: */
Method removed

https://codereview.appspot.com/19380044/diff/1/app/subapps/browser/views/bund...
app/subapps/browser/views/bundle.js:186: templateData.sourceLink =
this._getSourceLink();
I'm removing this custom version and changing the inherited version to take a
parameter for the branch_spec or code_source

[benji, 2013-10-30 19:04:32]

This is a test.  This is only a test.