Issue 1935046: PHP: Allow extending with new services without having to change ApiServlet code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1935046: PHP: Allow extending with new services without having to change ApiServlet code

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by bashofmann

Modified:
13 years, 8 months ago

Reviewers:
Paul Lindner

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

This patch addresses https://issues.apache.org/jira/browse/SHINDIG-705 and basically does the same as the patch provided by Erik Gomersbach but is based on the current trunk head.

Patch Set 1 #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+1051 lines, -853 lines)			Patch
php/config/container.php	View	2 chunks	+31 lines, -1 line	0 comments	Download
php/src/social/converters/InputActivitiesConverter.php	View	1 chunk	+40 lines, -0 lines	0 comments	Download
php/src/social/converters/InputAlbumsConverter.php	View	1 chunk	+40 lines, -0 lines	0 comments	Download
php/src/social/converters/InputAppDataConverter.php	View	1 chunk	+56 lines, -0 lines	0 comments	Download
php/src/social/converters/InputAtomConverter.php	View	1 chunk	+0 lines, -61 lines	0 comments	Download
php/src/social/converters/InputBasicXmlConverter.php	View	1 chunk	+1 line, -1 line	0 comments	Download
php/src/social/converters/InputConverter.php	View	1 chunk	+3 lines, -8 lines	0 comments	Download
php/src/social/converters/InputInvalidateConverter.php	View	1 chunk	+35 lines, -0 lines	0 comments	Download
php/src/social/converters/InputJsonConverter.php	View	1 chunk	+0 lines, -79 lines	0 comments	Download
php/src/social/converters/InputMediaItemsConverter.php	View	1 chunk	+42 lines, -0 lines	0 comments	Download
php/src/social/converters/InputMessagesConverter.php	View	1 chunk	+40 lines, -0 lines	0 comments	Download
php/src/social/converters/InputPeopleConverter.php	View	1 chunk	+34 lines, -0 lines	0 comments	Download
php/src/social/converters/InputXmlConverter.php	View	1 chunk	+0 lines, -63 lines	0 comments	Download
php/src/social/service/RestRequestItem.php	View	3 chunks	+19 lines, -39 lines	0 comments	Download
php/src/social/servlet/ApiServlet.php	View	3 chunks	+14 lines, -67 lines	0 comments	Download
php/src/social/servlet/DataServiceServlet.php	View	4 chunks	+10 lines, -10 lines	0 comments	Download
php/test/social/InputActivitiesConverterTest.php	View	1 chunk	+152 lines, -0 lines	0 comments	Download
php/test/social/InputAlbumsConverterTest.php	View	1 chunk	+114 lines, -0 lines	0 comments	Download
php/test/social/InputAppDataConverterTest.php	View	1 chunk	+90 lines, -0 lines	0 comments	Download
php/test/social/InputAtomConverterTest.php	View	1 chunk	+0 lines, -204 lines	0 comments	Download
php/test/social/InputInvalidateConverterTest.php	View	1 chunk	+65 lines, -0 lines	0 comments	Download
php/test/social/InputJsonConverterTest.php	View	1 chunk	+0 lines, -138 lines	0 comments	Download
php/test/social/InputMediaItemsConverterTest.php	View	1 chunk	+105 lines, -0 lines	0 comments	Download
php/test/social/InputMessagesConverterTest.php	View	1 chunk	+95 lines, -0 lines	0 comments	Download
php/test/social/InputPeopleConverterTest.php	View	1 chunk	+61 lines, -0 lines	0 comments	Download
php/test/social/InputXmlConverterTest.php	View	1 chunk	+0 lines, -174 lines	0 comments	Download
php/test/social/OutputAtomConverterTest.php	View	1 chunk	+1 line, -2 lines	0 comments	Download
php/test/social/OutputJsonConverterTest.php	View	1 chunk	+1 line, -2 lines	0 comments	Download
php/test/social/OutputXmlConverterTest.php	View	1 chunk	+1 line, -2 lines	0 comments	Download
php/test/social/RestRequestItemTest.php	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Paul Lindner

13 years, 8 months ago (2010-08-19 14:34:46 UTC) #2

no red flags observed.  thanks for following up on this!

Expand All Messages | Collapse All Messages