Issue 193500043: Small style tweaks to charts package that should not have a runtime impact.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 193500043: Small style tweaks to charts package that should not have a runtime impact.

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 3 months ago by jacobr

Modified:
9 years, 3 months ago

Reviewers:

Base URL:
git@github.com:google/charted.git@master

Visibility:
Public.

More Reviews

Description

Small style tweaks to charts package that should not have a runtime impact. Make implementation classes match the type signatures of base classes. Add a few generic types that weren't specified. Cleanup cases where a double was used as an index. Move super calls to end of constructor initialization list matching the Dart style guide. https://www.dartlang.org/articles/style-guide/#do-place-the-super-call-last-in-a-constructor-initialization-list BUG=

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -47 lines)			Patch
M	lib/charts/renderers/stackedbar_chart_renderer.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/charts/renderers/waterfall_chart_renderer.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/charts/src/chart_area_impl.dart	View	2 chunks	+8 lines, -7 lines	0 comments	Download
M	lib/charts/src/chart_config_impl.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/charts/src/chart_data_impl.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/charts/transformers/aggregation.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	lib/charts/transformers/aggregation_transformer.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	lib/charts/transformers/transpose_transformer.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/core/core.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/core/lists.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/core/rect.dart	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	lib/locale/number_format.dart	View	3 chunks	+6 lines, -9 lines	0 comments	Download
M	lib/locale/time_scale.dart	View	2 chunks	+7 lines, -4 lines	0 comments	Download
M	lib/selection/selection_impl.dart	View	6 chunks	+7 lines, -7 lines	0 comments	Download
M	lib/svg/svg_line.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download