Issue 193210043: Rev version for smoke due to breaking change switching the maximum number of args handled from 3 to…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 193210043: Rev version for smoke due to breaking change switching the maximum number of args handled from 3 to…

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 3 months ago by jacobr

Modified:
9 years, 3 months ago

Reviewers:

Base URL:
git@github.com:dart-lang/smoke.git@master

Visibility:
Public.

More Reviews

Description

Rev version for smoke due to breaking change switching the maximum number of args handled from 3 to 15 Extend minArgs and maxArgs methods to accept up to 15 arguments without much of a performance hit if #arguments < 4 BUG=

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+254 lines, -17 lines)			Patch
lib/src/common.dart	View	3 chunks	+53 lines, -5 lines	0 comments	Download
pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
test/args_test.dart	View	5 chunks	+200 lines, -11 lines	0 comments	Download