Issue 193098: Review: bug fix with shaders that have no 'main' instructions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 193098: Review: bug fix with shaders that have no 'main' instructions (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by larrygritz

Modified:
14 years, 2 months ago

Reviewers:
ckulla

CC:
dev-osl_imageworks.com, osl-dev_googlegroups.com

Base URL:
http://openshadinglanguage.googlecode.com/svn/trunk/

Visibility:
Public.

Description

It's possible to write a shader that has no instructions in the main program, but merely shuffles input params into output params (this is in fact done for certain "glue nodes" in shader networks). Due to a bug (mine), we never set the master's "maincodebegin" and "maincodeend" members, unless there actually was main code (which is the case for 99% of shaders, but...). Hilarity ensues. And multi-day bug hunts. Simple fix attached to initialize these, as well as a couple DASSERTS that I may as well leave in.

Patch Set 1 #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+4 lines, -0 lines)			Patch
src/liboslexec/exec.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
src/liboslexec/loadshader.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
src/liboslexec/master.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages