Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1101)

Issue 191900045: Support variation in repeated sections

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by Dan Eble
Modified:
9 years, 4 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Support variation in repeated sections. When repeats are unfolded, keep track of the current innermost volta number in the Timing context. Add a \conditional music function and predicate generators (only-in-nth-volta n) and (except-in-nth-volta n). When the predicate is false, the conditional music becomes a skip of the same duration. Example: \repeat volta 3 { \conditional #(except-in-nth-volta 1) {c^"1st time tacet" ...} } Prior discussion: http://lists.gnu.org/archive/html/lilypond-devel/2015-01/msg00095.html All comments are welcome, but be warned that questions along the lines of "Why did you do X?" might not receive a satisfactory answer. As always, thanks for your time.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -25 lines) Patch
A input/regression/repeat-unfold-except-in-nth.ly View 1 chunk +30 lines, -0 lines 0 comments Download
A input/regression/repeat-unfold-only-in-nth.ly View 1 chunk +29 lines, -0 lines 0 comments Download
M lily/include/music-wrapper-iterator.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/music-wrapper-iterator.cc View 1 chunk +7 lines, -2 lines 0 comments Download
A + lily/on-the-fly-music-iterator.cc View 2 chunks +17 lines, -15 lines 0 comments Download
M ly/music-functions-init.ly View 1 chunk +13 lines, -0 lines 0 comments Download
M scm/define-context-properties.scm View 1 chunk +3 lines, -1 line 0 comments Download
M scm/define-music-callbacks.scm View 1 chunk +50 lines, -7 lines 0 comments Download
M scm/define-music-types.scm View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 1
Dan Eble
9 years, 4 months ago (2015-01-11 19:47:59 UTC) #1

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b